paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 36 Packages Projects Releases Wiki Activity

Deep-import LightAsync to improve module-import time in tests

Browse Source 
`LightAsync` is a `react-syntax-highlighter` that defers the computation
of some fancy syntax-parsing logic.
However, `react-syntax-highlighter` exposes a `Light` variant that does
this computation up-front.

In runtime, tree-shaking ensures that we only import `LightAsync`, but
tree-shaking doesn't happen in tests (because it's slow).

So, deep-import to avoid incurring the syntax-parsing penalty when that
functionality isn't used in the test itself.

Signed-off-by: Mitchell Hentges <mhentges@spotify.com>
This commit is contained in:
Mitchell Hentges
2022-09-22 12:06:41 +02:00
parent aa5679b64f
commit 882101cd9b
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/eleven-apples-accept.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/core-components': patch
---
Deep-import LightAsync component to improve module-import speed
packages/core-components/src/components/CodeSnippet/CodeSnippet.tsx
+2 -1
View File
@@ -18,7 +18,8 @@ import React from 'react';
import { useTheme } from '@material-ui/core/styles';
import { BackstageTheme } from '@backstage/theme';
import { CopyTextButton } from '../CopyTextButton';
import { LightAsync } from 'react-syntax-highlighter';
import type {} from 'react-syntax-highlighter';
import { default as LightAsync } from 'react-syntax-highlighter/dist/esm/light-async';
import dark from 'react-syntax-highlighter/dist/esm/styles/hljs/dark';
import docco from 'react-syntax-highlighter/dist/esm/styles/hljs/docco';