From 87cabfed8c5386566b2206f3bf2a31312ed60d95 Mon Sep 17 00:00:00 2001 From: Damon Kaswell Date: Tue, 22 Nov 2022 07:28:41 -0800 Subject: [PATCH] Use stringifyerror Signed-off-by: Damon Kaswell --- plugins/incremental-ingestion-backend/package.json | 1 + .../src/engine/IncrementalIngestionEngine.ts | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/incremental-ingestion-backend/package.json b/plugins/incremental-ingestion-backend/package.json index 8d47121c8d..cd332f7986 100644 --- a/plugins/incremental-ingestion-backend/package.json +++ b/plugins/incremental-ingestion-backend/package.json @@ -33,6 +33,7 @@ }, "dependencies": { "@backstage/backend-common": "workspace:^", + "@backstage/errors": "workspace:^", "@backstage/backend-plugin-api": "workspace:^", "@backstage/backend-tasks": "workspace:^", "@backstage/catalog-model": "workspace:^", diff --git a/plugins/incremental-ingestion-backend/src/engine/IncrementalIngestionEngine.ts b/plugins/incremental-ingestion-backend/src/engine/IncrementalIngestionEngine.ts index 8510881c25..d88efdfbdb 100644 --- a/plugins/incremental-ingestion-backend/src/engine/IncrementalIngestionEngine.ts +++ b/plugins/incremental-ingestion-backend/src/engine/IncrementalIngestionEngine.ts @@ -26,6 +26,7 @@ import type { AbortSignal } from 'node-abort-controller'; import { performance } from 'perf_hooks'; import { Duration, DurationObjectUnits } from 'luxon'; import { v4 } from 'uuid'; +import { stringifyError } from '@backstage/errors'; export class IncrementalIngestionEngine implements IterationEngine { restLength: Duration; @@ -118,10 +119,7 @@ export class IncrementalIngestionEngine implements IterationEngine { const backoffLength = currentBackoff.as('milliseconds'); this.options.logger.error(error); - const truncatedError = - typeof error === 'string' - ? error.substring(0, 700) - : `${error}`; + const truncatedError = stringifyError(error).substring(0, 700); this.options.logger.error( `incremental-engine: Ingestion '${ingestionId}' threw an error during ingestion burst. Ingestion will backoff for ${currentBackoff.toHuman()} (${truncatedError})`, );