From 86ec8e170b595d2c756e206873e74af67bf10b2d Mon Sep 17 00:00:00 2001 From: blam Date: Fri, 30 Aug 2024 13:11:43 +0200 Subject: [PATCH] chore: added a console warning for deprecation as it's a little tricky to do in typescript Signed-off-by: blam --- .../src/wiring/resolveExtensionDefinition.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/frontend-plugin-api/src/wiring/resolveExtensionDefinition.ts b/packages/frontend-plugin-api/src/wiring/resolveExtensionDefinition.ts index 870fb258f5..a6be1ded97 100644 --- a/packages/frontend-plugin-api/src/wiring/resolveExtensionDefinition.ts +++ b/packages/frontend-plugin-api/src/wiring/resolveExtensionDefinition.ts @@ -149,6 +149,7 @@ export function resolveExtensionDefinition< override: _skip2, ...rest } = internalDefinition; + const namespace = internalDefinition.namespace ?? context?.namespace; const namePart = @@ -161,6 +162,13 @@ export function resolveExtensionDefinition< const id = kind ? `${kind}:${namePart}` : namePart; + if (internalDefinition.namespace) { + // eslint-disable-next-line no-console + console.warn( + `Extension ${id} has a deprecated namespace set, this option is no longer required, and should be removed from createExtensionBlueprint or createExtension. It will be automatically set from the pluginId when installing extensions using createFrontendModule and createFrontendPlugin`, + ); + } + return { ...rest, $$type: '@backstage/Extension',