From 8697dea5b46d721c0e218a1f8925da9ff843198c Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu, 26 Nov 2020 19:30:05 +0100
Subject: [PATCH] build(deps): bump rollup from 2.23.0 to 2.33.3 (#3434)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* build(deps): bump rollup from 2.23.0 to 2.33.3

Bumps [rollup](https://github.com/rollup/rollup) from 2.23.0 to 2.33.3.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v2.23.0...v2.33.3)

Signed-off-by: dependabot[bot] <support@github.com>

* fix types

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/shy-humans-protect.md             |  5 +++++
 packages/cli/package.json                    |  2 +-
 packages/cli/src/lib/builder/plugins.test.ts | 12 ++++++------
 yarn.lock                                    |  8 ++++----
 4 files changed, 16 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/shy-humans-protect.md

diff --git a/.changeset/shy-humans-protect.md b/.changeset/shy-humans-protect.md
new file mode 100644
index 0000000000..612cb9faf8
--- /dev/null
+++ b/.changeset/shy-humans-protect.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Bump Rollup
diff --git a/packages/cli/package.json b/packages/cli/package.json
index 034c8a3de5..b79a8ec37a 100644
--- a/packages/cli/package.json
+++ b/packages/cli/package.json
@@ -86,7 +86,7 @@
     "react-hot-loader": "^4.12.21",
     "recursive-readdir": "^2.2.2",
     "replace-in-file": "^6.0.0",
-    "rollup": "2.23.x",
+    "rollup": "2.33.x",
     "rollup-plugin-dts": "1.4.13",
     "rollup-plugin-esbuild": "^2.0.0",
     "rollup-plugin-peer-deps-external": "^2.2.2",
diff --git a/packages/cli/src/lib/builder/plugins.test.ts b/packages/cli/src/lib/builder/plugins.test.ts
index 41504a700e..d1e1b3e2bd 100644
--- a/packages/cli/src/lib/builder/plugins.test.ts
+++ b/packages/cli/src/lib/builder/plugins.test.ts
@@ -38,11 +38,11 @@ describe('forwardFileImports', () => {
     expect(plugin.name).toBe('forward-file-imports');
   });
 
-  it('should call through to original external option', () => {
+  it('should call through to original external option', async () => {
     const plugin = forwardFileImports({ include: /\.png$/ });
     const external = jest.fn((id: string) => id.endsWith('external'));
 
-    const options = plugin.options?.call(context, { external })!;
+    const options = (await plugin.options?.call(context, { external }))!;
     if (typeof options.external !== 'function') {
       throw new Error('options.external is not a function');
     }
@@ -70,12 +70,12 @@ describe('forwardFileImports', () => {
     ).toThrow('Unknown importer of file module ./my-image.png');
   });
 
-  it('should handle original external array', () => {
+  it('should handle original external array', async () => {
     const plugin = forwardFileImports({ include: /\.png$/ });
 
-    const options = plugin.options?.call(context, {
+    const options = (await plugin.options?.call(context, {
       external: ['my-external'],
-    })!;
+    }))!;
     if (typeof options.external !== 'function') {
       throw new Error('options.external is not a function');
     }
@@ -106,7 +106,7 @@ describe('forwardFileImports', () => {
     it('should extract files', async () => {
       const plugin = forwardFileImports({ include: /\.png$/ });
 
-      const options = plugin.options?.call(context, {})!;
+      const options = (await plugin.options?.call(context, {}))!;
       if (typeof options.external !== 'function') {
         throw new Error('options.external is not a function');
       }
diff --git a/yarn.lock b/yarn.lock
index 576db3b66c..4856559521 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -21188,10 +21188,10 @@ rollup-pluginutils@^2.8.2:
   dependencies:
     estree-walker "^0.6.1"
 
-rollup@2.23.x:
-  version "2.23.0"
-  resolved "https://registry.npmjs.org/rollup/-/rollup-2.23.0.tgz#b7ab1fee0c0e60132fd0553c4df1e9cdacfada9d"
-  integrity sha512-vLNmZFUGVwrnqNAJ/BvuLk1MtWzu4IuoqsH9UWK5AIdO3rt8/CSiJNvPvCIvfzrbNsqKbNzPAG1V2O4eTe2XZg==
+rollup@2.33.x:
+  version "2.33.3"
+  resolved "https://registry.npmjs.org/rollup/-/rollup-2.33.3.tgz#ae72ce31f992b09a580072951bfea76e9df17342"
+  integrity sha512-RpayhPTe4Gu/uFGCmk7Gp5Z9Qic2VsqZ040G+KZZvsZYdcuWaJg678JeDJJvJeEQXminu24a2au+y92CUWVd+w==
   optionalDependencies:
     fsevents "~2.1.2"