From 85e6fa20a782d17194875c36a81e5043a56b8099 Mon Sep 17 00:00:00 2001 From: benjdlambert Date: Tue, 19 Aug 2025 09:40:21 +0200 Subject: [PATCH] chore: update docs and fix naming Signed-off-by: benjdlambert --- docs/features/kubernetes/installation.md | 20 ++++++++++++++++--- plugins/kubernetes-backend/src/plugin.ts | 2 +- ...nitializer.ts => KubernetesInitializer.ts} | 0 3 files changed, 18 insertions(+), 4 deletions(-) rename plugins/kubernetes-backend/src/service/{KubernetnesInitializer.ts => KubernetesInitializer.ts} (100%) diff --git a/docs/features/kubernetes/installation.md b/docs/features/kubernetes/installation.md index a99bd0b429..6649ff78c1 100644 --- a/docs/features/kubernetes/installation.md +++ b/docs/features/kubernetes/installation.md @@ -87,6 +87,7 @@ import { ClusterDetails, KubernetesClustersSupplier, kubernetesClusterSupplierExtensionPoint, + kubernetesServiceLocatorExtensionPoint, } from '@backstage/plugin-kubernetes-node'; export class CustomClustersSupplier implements KubernetesClustersSupplier { @@ -119,12 +120,25 @@ export const kubernetesModuleCustomClusterDiscovery = createBackendModule({ register(env) { env.registerInit({ deps: { - kubernetes: kubernetesClusterSupplierExtensionPoint, + clusterSupplier: kubernetesClusterSupplierExtensionPoint, + serviceLocator: kubernetesServiceLocatorExtensionPoint, }, - async init({ kubernetes }) { - kubernetes.addClusterSupplier( + async init({ clusterSupplier }) { + clusterSupplier.addClusterSupplier( CustomClustersSupplier.create(Duration.fromObject({ minutes: 60 })), ); + + // there's also the ability to get access to some of the default implementations of the extension points where + // neccessary: + serviceLocator.addServiceLocator( + async ({ getDefault, clusterSupplier }) => { + // get access to the default service locator: + const defaultImplementation = await getDefault(); + + // build your own with the clusterSupplier dependency: + return MyNewServiceLocator({ clusterSupplier }); + }, + ); }, }); }, diff --git a/plugins/kubernetes-backend/src/plugin.ts b/plugins/kubernetes-backend/src/plugin.ts index a7bd323068..b4283d4914 100644 --- a/plugins/kubernetes-backend/src/plugin.ts +++ b/plugins/kubernetes-backend/src/plugin.ts @@ -42,7 +42,7 @@ import { KubernetesServiceLocatorFactory, } from '@backstage/plugin-kubernetes-node'; import { KubernetesRouter } from './service/KubernetesRouter'; -import { KubernetesInitializer } from './service/KubernetnesInitializer'; +import { KubernetesInitializer } from './service/KubernetesInitializer'; class ObjectsProvider implements KubernetesObjectsProviderExtensionPoint { private objectsProvider: KubernetesObjectsProviderFactory | undefined; diff --git a/plugins/kubernetes-backend/src/service/KubernetnesInitializer.ts b/plugins/kubernetes-backend/src/service/KubernetesInitializer.ts similarity index 100% rename from plugins/kubernetes-backend/src/service/KubernetnesInitializer.ts rename to plugins/kubernetes-backend/src/service/KubernetesInitializer.ts