From 4d58d1ebf682c005c61fc1a6b25cc1d4dae8b87e Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 13 Aug 2021 12:19:18 -0500 Subject: [PATCH 01/11] Add props to support the custom templateCard component Signed-off-by: victormorfin97 --- plugins/scaffolder/src/components/Router.tsx | 11 ++++++++-- .../ScaffolderPage/ScaffolderPage.tsx | 14 ++++++++---- .../components/TemplateList/TemplateList.tsx | 22 +++++++++++++------ 3 files changed, 34 insertions(+), 13 deletions(-) diff --git a/plugins/scaffolder/src/components/Router.tsx b/plugins/scaffolder/src/components/Router.tsx index 3d7bbcaf5f..3d7badc6e7 100644 --- a/plugins/scaffolder/src/components/Router.tsx +++ b/plugins/scaffolder/src/components/Router.tsx @@ -29,7 +29,11 @@ import { } from '../extensions'; import { useElementFilter } from '@backstage/core-plugin-api'; -export const Router = () => { +type RouterProps = { + renderTemplateCard?: Function | undefined; +}; + +export const Router = ({ renderTemplateCard }: RouterProps) => { const outlet = useOutlet(); const customFieldExtensions = useElementFilter(outlet, elements => @@ -54,7 +58,10 @@ export const Router = () => { return ( - } /> + } + /> } diff --git a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx index 859e5bba93..a9b8c1b573 100644 --- a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx +++ b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx @@ -46,7 +46,13 @@ const useStyles = makeStyles(theme => ({ }, })); -export const ScaffolderPageContents = () => { +export type ScaffolderPageProps = { + renderTemplateCard: Function | undefined; +}; + +export const ScaffolderPageContents = ({ + renderTemplateCard, +}: ScaffolderPageProps) => { const styles = useStyles(); const registerComponentLink = useRouteRef(registerComponentRouteRef); @@ -87,7 +93,7 @@ export const ScaffolderPageContents = () => {
- +
@@ -95,8 +101,8 @@ export const ScaffolderPageContents = () => { ); }; -export const ScaffolderPage = () => ( +export const ScaffolderPage = ({ renderTemplateCard }: ScaffolderPageProps) => ( - + ); diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index 009342c379..8fe56d4a5f 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -25,7 +25,11 @@ import { useEntityListProvider } from '@backstage/plugin-catalog-react'; import { Link, Typography } from '@material-ui/core'; import { TemplateCard } from '../TemplateCard'; -export const TemplateList = () => { +export type TemplateListProps = { + renderTemplateCard?: Function | undefined; +}; + +export const TemplateList = ({ renderTemplateCard }: TemplateListProps) => { const { loading, error, entities } = useEntityListProvider(); return ( <> @@ -50,12 +54,16 @@ export const TemplateList = () => { {entities && entities?.length > 0 && - entities.map((template, i) => ( - - ))} + entities.map((template, i) => + renderTemplateCard ? ( + renderTemplateCard(i, template) + ) : ( + + ), + )} ); From 3f4830ff649f0a1d90dfd3383facac61e75aa633 Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 13 Aug 2021 13:35:28 -0500 Subject: [PATCH 02/11] export things to replicate the templateCard Signed-off-by: victormorfin97 --- .../src/components/FavouriteTemplate/index.ts | 17 +++++++++++++++++ plugins/scaffolder/src/index.ts | 2 ++ 2 files changed, 19 insertions(+) create mode 100644 plugins/scaffolder/src/components/FavouriteTemplate/index.ts diff --git a/plugins/scaffolder/src/components/FavouriteTemplate/index.ts b/plugins/scaffolder/src/components/FavouriteTemplate/index.ts new file mode 100644 index 0000000000..5955e88c01 --- /dev/null +++ b/plugins/scaffolder/src/components/FavouriteTemplate/index.ts @@ -0,0 +1,17 @@ +/* + * Copyright 2020 The Backstage Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export * from './FavouriteTemplate'; diff --git a/plugins/scaffolder/src/index.ts b/plugins/scaffolder/src/index.ts index 989b3b53ce..8a7dea1c34 100644 --- a/plugins/scaffolder/src/index.ts +++ b/plugins/scaffolder/src/index.ts @@ -37,3 +37,5 @@ export { RepoUrlPicker, TextValuePicker, } from './components/fields'; +export { FavouriteTemplate } from './components/FavouriteTemplate'; +export { rootRouteRef as scaffolderRootRouteRef } from './routes'; From 34e14fdf7e59b87db3ec08b1b5a6d9767a735986 Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 13 Aug 2021 13:53:17 -0500 Subject: [PATCH 03/11] Add changeset Signed-off-by: victormorfin97 --- .changeset/beige-glasses-dream.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-glasses-dream.md diff --git a/.changeset/beige-glasses-dream.md b/.changeset/beige-glasses-dream.md new file mode 100644 index 0000000000..c1a9ad1857 --- /dev/null +++ b/.changeset/beige-glasses-dream.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Allow to pass custom TemplateCard to ScaffolderPage From c2d0bd6902a6b4c1fa364c728a3c84400ee52e5b Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 13 Aug 2021 16:16:56 -0500 Subject: [PATCH 04/11] renaming prop Signed-off-by: victormorfin97 --- plugins/scaffolder/src/components/Router.tsx | 6 +++--- .../src/components/ScaffolderPage/ScaffolderPage.tsx | 10 +++++----- .../src/components/TemplateList/TemplateList.tsx | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/plugins/scaffolder/src/components/Router.tsx b/plugins/scaffolder/src/components/Router.tsx index 3d7badc6e7..e317612d33 100644 --- a/plugins/scaffolder/src/components/Router.tsx +++ b/plugins/scaffolder/src/components/Router.tsx @@ -30,10 +30,10 @@ import { import { useElementFilter } from '@backstage/core-plugin-api'; type RouterProps = { - renderTemplateCard?: Function | undefined; + templateCard?: Function | undefined; }; -export const Router = ({ renderTemplateCard }: RouterProps) => { +export const Router = ({ templateCard }: RouterProps) => { const outlet = useOutlet(); const customFieldExtensions = useElementFilter(outlet, elements => @@ -60,7 +60,7 @@ export const Router = ({ renderTemplateCard }: RouterProps) => { } + element={} /> ({ })); export type ScaffolderPageProps = { - renderTemplateCard: Function | undefined; + templateCard: Function | undefined; }; export const ScaffolderPageContents = ({ - renderTemplateCard, + templateCard, }: ScaffolderPageProps) => { const styles = useStyles(); @@ -93,7 +93,7 @@ export const ScaffolderPageContents = ({
- +
@@ -101,8 +101,8 @@ export const ScaffolderPageContents = ({ ); }; -export const ScaffolderPage = ({ renderTemplateCard }: ScaffolderPageProps) => ( +export const ScaffolderPage = ({ templateCard }: ScaffolderPageProps) => ( - + ); diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index 8fe56d4a5f..3e13b82b2b 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -26,10 +26,10 @@ import { Link, Typography } from '@material-ui/core'; import { TemplateCard } from '../TemplateCard'; export type TemplateListProps = { - renderTemplateCard?: Function | undefined; + templateCard?: Function | undefined; }; -export const TemplateList = ({ renderTemplateCard }: TemplateListProps) => { +export const TemplateList = ({ templateCard }: TemplateListProps) => { const { loading, error, entities } = useEntityListProvider(); return ( <> @@ -55,8 +55,8 @@ export const TemplateList = ({ renderTemplateCard }: TemplateListProps) => { {entities && entities?.length > 0 && entities.map((template, i) => - renderTemplateCard ? ( - renderTemplateCard(i, template) + templateCard ? ( + templateCard(i, template) ) : ( Date: Thu, 19 Aug 2021 11:19:24 -0500 Subject: [PATCH 05/11] Change name & form of the new prop Signed-off-by: victormorfin97 --- plugins/scaffolder/src/components/Router.tsx | 8 +++++--- .../components/ScaffolderPage/ScaffolderPage.tsx | 12 +++++++----- .../src/components/TemplateList/TemplateList.tsx | 15 ++++++++++----- 3 files changed, 22 insertions(+), 13 deletions(-) diff --git a/plugins/scaffolder/src/components/Router.tsx b/plugins/scaffolder/src/components/Router.tsx index e317612d33..6a08d46ec9 100644 --- a/plugins/scaffolder/src/components/Router.tsx +++ b/plugins/scaffolder/src/components/Router.tsx @@ -30,10 +30,10 @@ import { import { useElementFilter } from '@backstage/core-plugin-api'; type RouterProps = { - templateCard?: Function | undefined; + TemplateCardComponent?: (props: any) => JSX.Element | null; }; -export const Router = ({ templateCard }: RouterProps) => { +export const Router = ({ TemplateCardComponent }: RouterProps) => { const outlet = useOutlet(); const customFieldExtensions = useElementFilter(outlet, elements => @@ -60,7 +60,9 @@ export const Router = ({ templateCard }: RouterProps) => { } + element={ + + } /> ({ })); export type ScaffolderPageProps = { - templateCard: Function | undefined; + TemplateCardComponent?: (props: any) => JSX.Element | null; }; export const ScaffolderPageContents = ({ - templateCard, + TemplateCardComponent, }: ScaffolderPageProps) => { const styles = useStyles(); @@ -93,7 +93,7 @@ export const ScaffolderPageContents = ({
- +
@@ -101,8 +101,10 @@ export const ScaffolderPageContents = ({ ); }; -export const ScaffolderPage = ({ templateCard }: ScaffolderPageProps) => ( +export const ScaffolderPage = ({ + TemplateCardComponent, +}: ScaffolderPageProps) => ( - + ); diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index 3e13b82b2b..b90ed1d8a6 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -23,13 +23,15 @@ import { } from '@backstage/core-components'; import { useEntityListProvider } from '@backstage/plugin-catalog-react'; import { Link, Typography } from '@material-ui/core'; -import { TemplateCard } from '../TemplateCard'; +import { TemplateCard, TemplateCardProps } from '../TemplateCard'; + +export type Props = TemplateCardProps; export type TemplateListProps = { - templateCard?: Function | undefined; + TemplateCardComponent?: (props: Props) => JSX.Element | null; }; -export const TemplateList = ({ templateCard }: TemplateListProps) => { +export const TemplateList = ({ TemplateCardComponent }: TemplateListProps) => { const { loading, error, entities } = useEntityListProvider(); return ( <> @@ -55,8 +57,11 @@ export const TemplateList = ({ templateCard }: TemplateListProps) => { {entities && entities?.length > 0 && entities.map((template, i) => - templateCard ? ( - templateCard(i, template) + TemplateCardComponent ? ( + ) : ( Date: Thu, 19 Aug 2021 11:20:00 -0500 Subject: [PATCH 06/11] removing unnecessary export Signed-off-by: victormorfin97 --- plugins/scaffolder/src/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/scaffolder/src/index.ts b/plugins/scaffolder/src/index.ts index 8a7dea1c34..c0e652b44c 100644 --- a/plugins/scaffolder/src/index.ts +++ b/plugins/scaffolder/src/index.ts @@ -38,4 +38,3 @@ export { TextValuePicker, } from './components/fields'; export { FavouriteTemplate } from './components/FavouriteTemplate'; -export { rootRouteRef as scaffolderRootRouteRef } from './routes'; From 00864470ecbcfbef9200a0bfdb8e2d2fcd4aef87 Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Tue, 24 Aug 2021 08:56:07 -0500 Subject: [PATCH 07/11] updating the api report Signed-off-by: victormorfin97 --- plugins/scaffolder/api-report.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/plugins/scaffolder/api-report.md b/plugins/scaffolder/api-report.md index 4df2a0808c..6981693a32 100644 --- a/plugins/scaffolder/api-report.md +++ b/plugins/scaffolder/api-report.md @@ -8,12 +8,15 @@ import { ApiHolder } from '@backstage/core-plugin-api'; import { ApiRef } from '@backstage/core-plugin-api'; import { BackstagePlugin } from '@backstage/core-plugin-api'; +import { ComponentProps } from 'react'; import { DiscoveryApi } from '@backstage/core-plugin-api'; +import { Entity } from '@backstage/catalog-model'; import { EntityName } from '@backstage/catalog-model'; import { Extension } from '@backstage/core-plugin-api'; import { ExternalRouteRef } from '@backstage/core-plugin-api'; import { FieldProps } from '@rjsf/core'; import { FieldValidation } from '@rjsf/core'; +import { IconButton } from '@material-ui/core'; import { IdentityApi } from '@backstage/core-plugin-api'; import { JsonObject } from '@backstage/config'; import { JSONSchema } from '@backstage/catalog-model'; @@ -73,6 +76,13 @@ export const EntityPicker: ({ // @public (undocumented) export const EntityPickerFieldExtension: () => null; +// Warning: (tsdoc-param-tag-missing-hyphen) The @param block should be followed by a parameter name and then a hyphen +// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts +// Warning: (ae-missing-release-tag) "FavouriteTemplate" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) +// +// @public +export const FavouriteTemplate: (props: Props) => JSX.Element; + // Warning: (ae-missing-release-tag) "FieldExtensionOptions" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // // @public (undocumented) @@ -203,7 +213,11 @@ export const ScaffolderFieldExtensions: React_2.ComponentType; // Warning: (ae-missing-release-tag) "ScaffolderPage" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // // @public (undocumented) -export const ScaffolderPage: () => JSX.Element; +export const ScaffolderPage: ({ + TemplateCardComponent, +}: { + TemplateCardComponent?: ((props: any) => JSX.Element | null) | undefined; +}) => JSX.Element; // Warning: (ae-missing-release-tag) "scaffolderPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // From 342e1c5cfc72ed287446435c9bdc38565fac16ab Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 27 Aug 2021 08:17:51 -0500 Subject: [PATCH 08/11] update to the correct type the new prop Signed-off-by: victormorfin97 --- plugins/scaffolder/src/components/Router.tsx | 7 +++++-- .../src/components/ScaffolderPage/ScaffolderPage.tsx | 7 +++++-- .../src/components/TemplateList/TemplateList.tsx | 6 ++++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/plugins/scaffolder/src/components/Router.tsx b/plugins/scaffolder/src/components/Router.tsx index 6a08d46ec9..9e4736ab9f 100644 --- a/plugins/scaffolder/src/components/Router.tsx +++ b/plugins/scaffolder/src/components/Router.tsx @@ -14,8 +14,9 @@ * limitations under the License. */ -import React from 'react'; +import React, { ComponentType } from 'react'; import { Routes, Route, useOutlet } from 'react-router'; +import { TemplateEntityV1beta2 } from '@backstage/catalog-model'; import { ScaffolderPage } from './ScaffolderPage'; import { TemplatePage } from './TemplatePage'; import { TaskPage } from './TaskPage'; @@ -30,7 +31,9 @@ import { import { useElementFilter } from '@backstage/core-plugin-api'; type RouterProps = { - TemplateCardComponent?: (props: any) => JSX.Element | null; + TemplateCardComponent?: + | ComponentType<{ template: TemplateEntityV1beta2 }> + | undefined; }; export const Router = ({ TemplateCardComponent }: RouterProps) => { diff --git a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx index e0d6a7b565..ec7bd6f468 100644 --- a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx +++ b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPage.tsx @@ -23,6 +23,7 @@ import { Page, SupportButton, } from '@backstage/core-components'; +import { TemplateEntityV1beta2 } from '@backstage/catalog-model'; import { useRouteRef } from '@backstage/core-plugin-api'; import { EntityKindPicker, @@ -32,7 +33,7 @@ import { UserListPicker, } from '@backstage/plugin-catalog-react'; import { makeStyles } from '@material-ui/core'; -import React from 'react'; +import React, { ComponentType } from 'react'; import { registerComponentRouteRef } from '../../routes'; import { TemplateList } from '../TemplateList'; import { TemplateTypePicker } from '../TemplateTypePicker'; @@ -47,7 +48,9 @@ const useStyles = makeStyles(theme => ({ })); export type ScaffolderPageProps = { - TemplateCardComponent?: (props: any) => JSX.Element | null; + TemplateCardComponent?: + | ComponentType<{ template: TemplateEntityV1beta2 }> + | undefined; }; export const ScaffolderPageContents = ({ diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index b90ed1d8a6..fb9a73f85e 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -14,7 +14,7 @@ * limitations under the License. */ -import React from 'react'; +import React, { ComponentType } from 'react'; import { TemplateEntityV1beta2 } from '@backstage/catalog-model'; import { ItemCardGrid, @@ -28,7 +28,9 @@ import { TemplateCard, TemplateCardProps } from '../TemplateCard'; export type Props = TemplateCardProps; export type TemplateListProps = { - TemplateCardComponent?: (props: Props) => JSX.Element | null; + TemplateCardComponent?: + | ComponentType<{ template: TemplateEntityV1beta2 }> + | undefined; }; export const TemplateList = ({ TemplateCardComponent }: TemplateListProps) => { From b21fb3ae269e69b77086a617b55498d9181db006 Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 27 Aug 2021 08:24:11 -0500 Subject: [PATCH 09/11] use a const instead of a condition to render the card component Signed-off-by: victormorfin97 --- .../components/TemplateList/TemplateList.tsx | 25 ++++++++----------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index fb9a73f85e..b23ef16eba 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -15,7 +15,10 @@ */ import React, { ComponentType } from 'react'; -import { TemplateEntityV1beta2 } from '@backstage/catalog-model'; +import { + stringifyEntityRef, + TemplateEntityV1beta2, +} from '@backstage/catalog-model'; import { ItemCardGrid, Progress, @@ -35,6 +38,7 @@ export type TemplateListProps = { export const TemplateList = ({ TemplateCardComponent }: TemplateListProps) => { const { loading, error, entities } = useEntityListProvider(); + const Card = TemplateCardComponent || TemplateCard; return ( <> {loading && } @@ -58,19 +62,12 @@ export const TemplateList = ({ TemplateCardComponent }: TemplateListProps) => { {entities && entities?.length > 0 && - entities.map((template, i) => - TemplateCardComponent ? ( - - ) : ( - - ), - )} + entities.map(template => ( + + ))} ); From a085b28f947f6e3481fc6bdbd4d8429940a3c5dc Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 27 Aug 2021 08:54:36 -0500 Subject: [PATCH 10/11] update the api report Signed-off-by: victormorfin97 --- plugins/scaffolder/api-report.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/plugins/scaffolder/api-report.md b/plugins/scaffolder/api-report.md index 6981693a32..8c87628d61 100644 --- a/plugins/scaffolder/api-report.md +++ b/plugins/scaffolder/api-report.md @@ -9,6 +9,7 @@ import { ApiHolder } from '@backstage/core-plugin-api'; import { ApiRef } from '@backstage/core-plugin-api'; import { BackstagePlugin } from '@backstage/core-plugin-api'; import { ComponentProps } from 'react'; +import { ComponentType } from 'react'; import { DiscoveryApi } from '@backstage/core-plugin-api'; import { Entity } from '@backstage/catalog-model'; import { EntityName } from '@backstage/catalog-model'; @@ -25,6 +26,7 @@ import { Observable } from '@backstage/core-plugin-api'; import { default as React_2 } from 'react'; import { RouteRef } from '@backstage/core-plugin-api'; import { ScmIntegrationRegistry } from '@backstage/integration'; +import { TemplateEntityV1beta2 } from '@backstage/catalog-model'; // Warning: (ae-missing-release-tag) "createScaffolderFieldExtension" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // @@ -216,7 +218,11 @@ export const ScaffolderFieldExtensions: React_2.ComponentType; export const ScaffolderPage: ({ TemplateCardComponent, }: { - TemplateCardComponent?: ((props: any) => JSX.Element | null) | undefined; + TemplateCardComponent?: + | ComponentType<{ + template: TemplateEntityV1beta2; + }> + | undefined; }) => JSX.Element; // Warning: (ae-missing-release-tag) "scaffolderPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) From 149fc41c95d3d9d341c8b3f0e87eed882dc6bc6d Mon Sep 17 00:00:00 2001 From: victormorfin97 Date: Fri, 27 Aug 2021 12:52:48 -0500 Subject: [PATCH 11/11] remove unused code Signed-off-by: victormorfin97 --- .../scaffolder/src/components/TemplateList/TemplateList.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx index b23ef16eba..dcf708db10 100644 --- a/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx +++ b/plugins/scaffolder/src/components/TemplateList/TemplateList.tsx @@ -26,9 +26,7 @@ import { } from '@backstage/core-components'; import { useEntityListProvider } from '@backstage/plugin-catalog-react'; import { Link, Typography } from '@material-ui/core'; -import { TemplateCard, TemplateCardProps } from '../TemplateCard'; - -export type Props = TemplateCardProps; +import { TemplateCard } from '../TemplateCard'; export type TemplateListProps = { TemplateCardComponent?: