From 846fb1ea57c292eb895feda23da548a38e225b97 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 16 Mar 2026 19:03:58 +0100 Subject: [PATCH] Fix TS2454 in createDevApp test Use definite assignment assertions for variables assigned inside jest.isolateModules callbacks. Signed-off-by: Patrik Oldsberg Made-with: Cursor --- .../src/createDevApp.test.tsx | 28 ++++++++++++------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/packages/frontend-dev-utils/src/createDevApp.test.tsx b/packages/frontend-dev-utils/src/createDevApp.test.tsx index b5beb79c1c..6624681152 100644 --- a/packages/frontend-dev-utils/src/createDevApp.test.tsx +++ b/packages/frontend-dev-utils/src/createDevApp.test.tsx @@ -25,6 +25,22 @@ jest.setTimeout(15000); const originalEnv = process.env; +function loadCreateDevAppIsolated(): typeof import('./createDevApp').createDevApp { + let isolatedCreateDevApp: + | typeof import('./createDevApp').createDevApp + | undefined; + + jest.isolateModules(() => { + ({ createDevApp: isolatedCreateDevApp } = require('./createDevApp')); + }); + + if (!isolatedCreateDevApp) { + throw new Error('Expected createDevApp to be loaded in isolation'); + } + + return isolatedCreateDevApp; +} + describe('createDevApp', () => { beforeEach(() => { process.env = { ...originalEnv }; @@ -105,11 +121,7 @@ describe('createDevApp', () => { root.id = 'root'; document.body.appendChild(root); - let isolatedCreateDevApp: typeof import('./createDevApp').createDevApp; - jest.isolateModules(() => { - ({ createDevApp: isolatedCreateDevApp } = require('./createDevApp')); - }); - + const isolatedCreateDevApp = loadCreateDevAppIsolated(); isolatedCreateDevApp({ bindRoutes, features: ['plugin-feature'] as any, @@ -160,11 +172,7 @@ describe('createDevApp', () => { root.id = 'root'; document.body.appendChild(root); - let isolatedCreateDevApp: typeof import('./createDevApp').createDevApp; - jest.isolateModules(() => { - ({ createDevApp: isolatedCreateDevApp } = require('./createDevApp')); - }); - + const isolatedCreateDevApp = loadCreateDevAppIsolated(); isolatedCreateDevApp({ features: ['plugin-feature'] as any, });