From 844757ef480a636733fba2d151727a4455a0fdc5 Mon Sep 17 00:00:00 2001 From: Tim Harris Date: Fri, 12 Aug 2022 12:18:48 -0400 Subject: [PATCH] Fixing issue #13126 Fixing evaluation grouping with ternary. Regex match was returning all archived repos as matching along with the ones that actually matched. Signed-off-by: Tim Harris Signed-off-by: Tim Harris --- .../src/providers/GitHubEntityProvider.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/catalog-backend-module-github/src/providers/GitHubEntityProvider.ts b/plugins/catalog-backend-module-github/src/providers/GitHubEntityProvider.ts index 991b380112..346d4d9097 100644 --- a/plugins/catalog-backend-module-github/src/providers/GitHubEntityProvider.ts +++ b/plugins/catalog-backend-module-github/src/providers/GitHubEntityProvider.ts @@ -185,9 +185,9 @@ export class GitHubEntityProvider implements EntityProvider { const repositoryFilter = this.config.filters?.repository; const matchingRepositories = repositories.filter(r => { - return !r.isArchived && repositoryFilter + return !r.isArchived && ( repositoryFilter ? repositoryFilter?.test(r.name) - : true && r.defaultBranchRef?.name; + : true && r.defaultBranchRef?.name) ; }); return matchingRepositories; }