From ba83266bf50ca4751cf75145427a89fb7f592d8f Mon Sep 17 00:00:00 2001 From: Raghunandan Balachandran Date: Tue, 4 Feb 2020 13:17:01 +0100 Subject: [PATCH 1/3] minor fixes / add grid to login page --- frontend/packages/app/src/App.tsx | 47 +++++++++---------- .../LoginComponent/LoginComponent.tsx | 31 +++++++++--- 2 files changed, 47 insertions(+), 31 deletions(-) diff --git a/frontend/packages/app/src/App.tsx b/frontend/packages/app/src/App.tsx index fa38461c01..7836f17c77 100644 --- a/frontend/packages/app/src/App.tsx +++ b/frontend/packages/app/src/App.tsx @@ -9,8 +9,8 @@ import { BrowserRouter as Router, Switch, Route, - Link as RouterLink -} from "react-router-dom"; + Link as RouterLink, +} from 'react-router-dom'; const useStyles = makeStyles(theme => ({ root: { @@ -26,7 +26,7 @@ const useStyles = makeStyles(theme => ({ overflowY: 'auto', }, pageBody: { - paddingLeft: theme.spacing(2), + paddingLeftß: theme.spacing(2), paddingTop: theme.spacing(2), }, avatarButton: { @@ -36,20 +36,21 @@ const useStyles = makeStyles(theme => ({ const App: FC<{}> = () => { return ( - - - - - - - - - - - - - - ); + + + + + + + + + + + + + + + ); }; const Home: FC<{}> = () => { @@ -75,10 +76,10 @@ const Login: FC<{}> = () => { Go to Home - ); -} + ); +}; -const AppShell: FC<{}> = ({children}) => { +const AppShell: FC<{}> = ({ children }) => { const classes = useStyles(); return ( @@ -86,12 +87,10 @@ const AppShell: FC<{}> = ({children}) => {
-
- {children} -
+
{children}
); -} +}; export default App; diff --git a/frontend/packages/plugins/login/src/components/LoginComponent/LoginComponent.tsx b/frontend/packages/plugins/login/src/components/LoginComponent/LoginComponent.tsx index a9dc81d93c..31caa7d4db 100644 --- a/frontend/packages/plugins/login/src/components/LoginComponent/LoginComponent.tsx +++ b/frontend/packages/plugins/login/src/components/LoginComponent/LoginComponent.tsx @@ -1,18 +1,35 @@ import React, { FC, Fragment } from 'react'; import Button from '@material-ui/core/Button'; import TextField from '@material-ui/core/TextField'; +import Grid from '@material-ui/core/Grid'; const LoginComponent: FC<{}> = () => { return ( - - + + ); }; From c82fac8af1b001f7b7493b48dac3f6a1f65d12c1 Mon Sep 17 00:00:00 2001 From: Raghunandan Balachandran Date: Tue, 4 Feb 2020 13:18:45 +0100 Subject: [PATCH 2/3] move app shell to the top --- frontend/packages/app/src/App.tsx | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/frontend/packages/app/src/App.tsx b/frontend/packages/app/src/App.tsx index 7836f17c77..a2bb08ac53 100644 --- a/frontend/packages/app/src/App.tsx +++ b/frontend/packages/app/src/App.tsx @@ -36,20 +36,18 @@ const useStyles = makeStyles(theme => ({ const App: FC<{}> = () => { return ( - - - - + + + + - - - - + + - - - - + + + + ); }; From f0b951fd138aa9a3a9d9691b8f1d407e4f6db834 Mon Sep 17 00:00:00 2001 From: Raghunandan Balachandran Date: Tue, 4 Feb 2020 13:29:44 +0100 Subject: [PATCH 3/3] fix typo --- frontend/packages/app/src/App.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/packages/app/src/App.tsx b/frontend/packages/app/src/App.tsx index a2bb08ac53..f51cf54d0b 100644 --- a/frontend/packages/app/src/App.tsx +++ b/frontend/packages/app/src/App.tsx @@ -26,7 +26,7 @@ const useStyles = makeStyles(theme => ({ overflowY: 'auto', }, pageBody: { - paddingLeftß: theme.spacing(2), + paddingLeft: theme.spacing(2), paddingTop: theme.spacing(2), }, avatarButton: {