diff --git a/.changeset/odd-gifts-decide.md b/.changeset/odd-gifts-decide.md new file mode 100644 index 0000000000..317191f4c6 --- /dev/null +++ b/.changeset/odd-gifts-decide.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Standardize on `classnames` instead of both that and `clsx`. diff --git a/packages/core-components/package.json b/packages/core-components/package.json index 0d17d30461..12f5474c44 100644 --- a/packages/core-components/package.json +++ b/packages/core-components/package.json @@ -41,7 +41,6 @@ "@types/react-text-truncate": "^0.14.0", "ansi-regex": "^5.0.1", "classnames": "^2.2.6", - "clsx": "^1.1.0", "d3-selection": "^3.0.0", "d3-shape": "^3.0.0", "d3-zoom": "^3.0.0", diff --git a/packages/core-components/src/components/LogViewer/LogLine.tsx b/packages/core-components/src/components/LogViewer/LogLine.tsx index c14df4a45a..ed3396360e 100644 --- a/packages/core-components/src/components/LogViewer/LogLine.tsx +++ b/packages/core-components/src/components/LogViewer/LogLine.tsx @@ -17,7 +17,7 @@ import React, { useMemo } from 'react'; import { AnsiChunk, AnsiLine, ChunkModifiers } from './AnsiProcessor'; import startCase from 'lodash/startCase'; -import clsx from 'clsx'; +import classnames from 'classnames'; import { useStyles } from './styles'; export function getModifierClasses( @@ -160,7 +160,7 @@ export function LogLine({ chunks.map(({ text, modifiers, highlight }, index) => ( (
@@ -82,7 +82,7 @@ export function RealLogViewer(props: RealLogViewerProps) { return (
diff --git a/packages/core-components/src/layout/Sidebar/Bar.tsx b/packages/core-components/src/layout/Sidebar/Bar.tsx index 775c537695..bada68a028 100644 --- a/packages/core-components/src/layout/Sidebar/Bar.tsx +++ b/packages/core-components/src/layout/Sidebar/Bar.tsx @@ -16,7 +16,7 @@ import { makeStyles } from '@material-ui/core/styles'; import useMediaQuery from '@material-ui/core/useMediaQuery'; -import clsx from 'clsx'; +import classnames from 'classnames'; import React, { useState, useContext, PropsWithChildren, useRef } from 'react'; import { sidebarConfig, SidebarContext } from './config'; import { BackstageTheme } from '@backstage/theme'; @@ -172,7 +172,7 @@ export function Sidebar(props: PropsWithChildren) { }} >
diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx index 903053eda4..c8c6db13a2 100644 --- a/packages/core-components/src/layout/Sidebar/Items.tsx +++ b/packages/core-components/src/layout/Sidebar/Items.tsx @@ -23,7 +23,7 @@ import Typography from '@material-ui/core/Typography'; import { CreateCSSProperties } from '@material-ui/core/styles/withStyles'; import ArrowRightIcon from '@material-ui/icons/ArrowRight'; import SearchIcon from '@material-ui/icons/Search'; -import clsx from 'clsx'; +import classnames from 'classnames'; import React, { Children, forwardRef, @@ -253,12 +253,12 @@ const SidebarItemWithSubmenu = ({ >
); }); @@ -388,7 +391,7 @@ export const SidebarItem = forwardRef((props, ref) => { variant="dot" overlap="circular" invisible={!hasNotifications} - className={clsx({ [classes.closedItemIcon]: !isOpen })} + className={classnames({ [classes.closedItemIcon]: !isOpen })} > @@ -414,7 +417,7 @@ export const SidebarItem = forwardRef((props, ref) => { const childProps = { onClick, - className: clsx( + className: classnames( className, classes.root, isOpen ? classes.open : classes.closed, diff --git a/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx b/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx index df671c7514..1e9afe86ef 100644 --- a/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx +++ b/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx @@ -15,7 +15,7 @@ */ import { makeStyles } from '@material-ui/core/styles'; import Typography from '@material-ui/core/Typography'; -import clsx from 'clsx'; +import classnames from 'classnames'; import React, { ReactNode, useContext } from 'react'; import { SidebarItemWithSubmenuContext, @@ -93,7 +93,7 @@ export const SidebarSubmenu = (props: SidebarSubmenuProps) => { const { isHoveredOn } = useContext(SidebarItemWithSubmenuContext); return (
diff --git a/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx b/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx index 2bb8a13592..56192ced77 100644 --- a/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx +++ b/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx @@ -24,7 +24,7 @@ import { makeStyles } from '@material-ui/core/styles'; import Typography from '@material-ui/core/Typography'; import Link from '@material-ui/core/Link'; import { IconComponent } from '@backstage/core-plugin-api'; -import clsx from 'clsx'; +import classnames from 'classnames'; import { BackstageTheme } from '@backstage/theme'; import ArrowDropDownIcon from '@material-ui/icons/ArrowDropDown'; import ArrowDropUpIcon from '@material-ui/icons/ArrowDropUp'; @@ -138,7 +138,7 @@ export const SidebarSubmenuItem = (props: SidebarSubmenuItemProps) => {