From 83e7ec63222bc41b26f9dd3e445e2ea397e3ecad Mon Sep 17 00:00:00 2001 From: nikolar Date: Wed, 28 Feb 2024 09:59:13 -0800 Subject: [PATCH] add review suggestion Signed-off-by: nikolar --- .changeset/perfect-shoes-arrive.md | 2 -- .../FeedbackResponseTable/FeedbackResponseTable.tsx | 12 +++++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.changeset/perfect-shoes-arrive.md b/.changeset/perfect-shoes-arrive.md index eaff65c082..93862df24d 100644 --- a/.changeset/perfect-shoes-arrive.md +++ b/.changeset/perfect-shoes-arrive.md @@ -2,6 +2,4 @@ '@backstage/plugin-entity-feedback': patch --- - - Remove empty Chip in `FeedbackResponseTable.tsx` when there is no response, and fix typo in Feedback Dialog Box. diff --git a/plugins/entity-feedback/src/components/FeedbackResponseTable/FeedbackResponseTable.tsx b/plugins/entity-feedback/src/components/FeedbackResponseTable/FeedbackResponseTable.tsx index 2a756ee105..8cede00878 100644 --- a/plugins/entity-feedback/src/components/FeedbackResponseTable/FeedbackResponseTable.tsx +++ b/plugins/entity-feedback/src/components/FeedbackResponseTable/FeedbackResponseTable.tsx @@ -80,11 +80,13 @@ export const FeedbackResponseTable = (props: FeedbackResponseTableProps) => { width: '35%', render: (response: ResponseRow) => ( <> - {response?.response && - response.response.length > 0 && - response.response - ?.split(',') - .map(res => )} + {(response.response || '') + .split(',') + .map(v => v.trim()) // removes whitespace + .filter(Boolean) // removes accidental empty entries + .map(res => ( + + ))} ), },