From b230d5a10a300203526c30f4c99c986541a006fb Mon Sep 17 00:00:00 2001
From: Robin Murphy <robin@monzo.com>
Date: Thu, 25 Feb 2021 14:34:21 +0000
Subject: [PATCH 1/4] OverflowTooltip: Don't render component when text is
 empty

Signed-off-by: Robin Murphy <robin@monzo.com>
---
 .../core/src/components/OverflowTooltip/OverflowTooltip.tsx   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx b/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
index faf064f9f4..1db9543462 100644
--- a/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
+++ b/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
@@ -40,6 +40,10 @@ export const OverflowTooltip = (props: Props) => {
     setHover(truncated);
   };
 
+  if (!props.text) {
+    return null;
+  }
+
   return (
     <Tooltip
       title={props.title ?? props.text!}

From a51fb698b78c0e5f869b5de427757b216913b72d Mon Sep 17 00:00:00 2001
From: Robin Murphy <robin@monzo.com>
Date: Thu, 25 Feb 2021 15:03:31 +0000
Subject: [PATCH 2/4] Add basic test

Signed-off-by: Robin Murphy <robin@monzo.com>
---
 .../OverflowTooltip/OverflowTooltip.test.tsx  | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 packages/core/src/components/OverflowTooltip/OverflowTooltip.test.tsx

diff --git a/packages/core/src/components/OverflowTooltip/OverflowTooltip.test.tsx b/packages/core/src/components/OverflowTooltip/OverflowTooltip.test.tsx
new file mode 100644
index 0000000000..52f44bb4d0
--- /dev/null
+++ b/packages/core/src/components/OverflowTooltip/OverflowTooltip.test.tsx
@@ -0,0 +1,30 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import React from 'react';
+import { render } from '@testing-library/react';
+
+import { OverflowTooltip } from '.';
+
+describe('<OverflowTooltip />', () => {
+  it('renders without exploding', async () => {
+    render(<OverflowTooltip text="Text that may overflow" />);
+  });
+
+  it('renders without exploding when the text prop is missing', async () => {
+    render(<OverflowTooltip text={undefined} />);
+  });
+});

From df59930b388da26c7ab9f420689f0d83fcee4e6f Mon Sep 17 00:00:00 2001
From: Robin Murphy <robin@monzo.com>
Date: Thu, 25 Feb 2021 15:06:33 +0000
Subject: [PATCH 3/4] Add changeset

Signed-off-by: Robin Murphy <robin@monzo.com>
---
 .changeset/yellow-bananas-live.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/yellow-bananas-live.md

diff --git a/.changeset/yellow-bananas-live.md b/.changeset/yellow-bananas-live.md
new file mode 100644
index 0000000000..82a3ce8b15
--- /dev/null
+++ b/.changeset/yellow-bananas-live.md
@@ -0,0 +1,5 @@
+---
+'@backstage/core': patch
+---
+
+Fix PropTypes error with OverflowTooltip component

From db4bf2edc165c94bed26a952e64c3f41e489f8ba Mon Sep 17 00:00:00 2001
From: Robin Murphy <robin@monzo.com>
Date: Mon, 22 Mar 2021 17:05:55 +0000
Subject: [PATCH 4/4] Default title to empty string

Signed-off-by: Robin Murphy <robin@monzo.com>
---
 .../core/src/components/OverflowTooltip/OverflowTooltip.tsx | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx b/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
index 1db9543462..b7bad6f377 100644
--- a/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
+++ b/packages/core/src/components/OverflowTooltip/OverflowTooltip.tsx
@@ -40,13 +40,9 @@ export const OverflowTooltip = (props: Props) => {
     setHover(truncated);
   };
 
-  if (!props.text) {
-    return null;
-  }
-
   return (
     <Tooltip
-      title={props.title ?? props.text!}
+      title={props.title ?? (props.text || '')}
       placement={props.placement}
       disableHoverListener={!hover}
     >