From 83ac69be864848c5b4b6210497ecceefe5fe5b48 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@spotify.com>
Date: Sat, 18 Apr 2026 22:50:30 +0200
Subject: [PATCH] Fix ListTaskPage test to match simplified OwnerEntityColumn
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Update assertions to expect the entity presentation short ref (e.g.
'foo') instead of the old catalog-resolved display name (e.g.
'BackUser'), and remove now-unused entity fixtures and catalog API
mocking.

Signed-off-by: Fredrik Adelöw <freben@spotify.com>
Made-with: Cursor
---
 .../ListTasksPage/ListTaskPage.test.tsx       | 56 +------------------
 1 file changed, 2 insertions(+), 54 deletions(-)

diff --git a/plugins/scaffolder/src/components/ListTasksPage/ListTaskPage.test.tsx b/plugins/scaffolder/src/components/ListTasksPage/ListTaskPage.test.tsx
index 9843ebb5ee..ec144f4b51 100644
--- a/plugins/scaffolder/src/components/ListTasksPage/ListTaskPage.test.tsx
+++ b/plugins/scaffolder/src/components/ListTasksPage/ListTaskPage.test.tsx
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { Entity } from '@backstage/catalog-model';
 import {
   renderInTestApp,
   TestApiProvider,
@@ -46,20 +45,6 @@ describe('<ListTasksPage />', () => {
   const mockPermissionApi = { authorize: jest.fn() };
 
   it('should render the page', async () => {
-    const entity: Entity = {
-      apiVersion: 'v1',
-      kind: 'service',
-      metadata: {
-        name: 'test',
-      },
-      spec: {
-        profile: {
-          displayName: 'BackUser',
-        },
-      },
-    };
-    catalogApi.getEntityByRef.mockResolvedValue(entity);
-
     scaffolderApiMock.listTasks.mockResolvedValue({ tasks: [], totalTasks: 0 });
 
     const { getByText } = await renderInTestApp(
@@ -87,19 +72,6 @@ describe('<ListTasksPage />', () => {
   });
 
   it('should render the task I am owner', async () => {
-    const entity: Entity = {
-      apiVersion: 'v1',
-      kind: 'User',
-      metadata: {
-        name: 'foo',
-      },
-      spec: {
-        profile: {
-          displayName: 'BackUser',
-        },
-      },
-    };
-    catalogApi.getEntityByRef.mockResolvedValue(entity);
     scaffolderApiMock.listTasks.mockResolvedValue({
       tasks: [
         {
@@ -151,34 +123,10 @@ describe('<ListTasksPage />', () => {
     expect(getByText('All tasks that have been started')).toBeInTheDocument();
     expect(getByText('Tasks')).toBeInTheDocument();
     expect(await findByText('One Template')).toBeInTheDocument();
-    expect(await findByText('BackUser')).toBeInTheDocument();
+    expect(await findByText('foo')).toBeInTheDocument();
   });
 
   it('should render all tasks', async () => {
-    const entity: Entity = {
-      apiVersion: 'v1',
-      kind: 'User',
-      metadata: {
-        name: 'foo',
-      },
-      spec: {
-        profile: {
-          displayName: 'BackUser',
-        },
-      },
-    };
-    catalogApi.getEntityByRef
-      .mockResolvedValue(entity)
-      .mockResolvedValue(entity)
-      .mockResolvedValue({
-        ...entity,
-        spec: {
-          profile: {
-            displayName: 'OtherUser',
-          },
-        },
-      });
-
     scaffolderApiMock.listTasks
       .mockResolvedValue({
         tasks: [
@@ -252,6 +200,6 @@ describe('<ListTasksPage />', () => {
       offset: 0,
     });
     expect(await findByText('One Template')).toBeInTheDocument();
-    expect(await findByText('OtherUser')).toBeInTheDocument();
+    expect(await findByText('boo')).toBeInTheDocument();
   });
 });