fix(explore): don't put ? if no query parameters
Signed-off-by: jean-philippe.blary <jean-philippe.blary@ovhcloud.com>
This commit is contained in:
@@ -83,6 +83,22 @@ describe('ExploreClient', () => {
|
||||
});
|
||||
expect(response).toEqual(expectedResponse);
|
||||
});
|
||||
|
||||
it('should request explore tools without filters', async () => {
|
||||
const expectedResponse: GetExploreToolsResponse = {
|
||||
tools: mockTools,
|
||||
};
|
||||
|
||||
server.use(
|
||||
rest.get(`${mockBaseUrl}/tools`, (req, res, ctx) => {
|
||||
expect(req.url.search).toBe('');
|
||||
return res(ctx.json(expectedResponse));
|
||||
}),
|
||||
);
|
||||
|
||||
const response = await client.getTools();
|
||||
expect(response).toEqual(expectedResponse);
|
||||
});
|
||||
});
|
||||
|
||||
describe('when using exploreToolsConfig for backwards compatibility', () => {
|
||||
|
||||
@@ -71,7 +71,7 @@ export class ExploreClient implements ExploreApi {
|
||||
filter?.lifecycle?.map(l => `lifecycle=${encodeURIComponent(l)}`) ?? [];
|
||||
const query = [...tags, ...lifecycles].join('&');
|
||||
|
||||
const response = await fetch(`${baseUrl}/tools?${query}`);
|
||||
const response = await fetch(`${baseUrl}/tools${query ? `?${query}` : ''}`);
|
||||
|
||||
if (!response.ok) {
|
||||
throw await ResponseError.fromResponse(response);
|
||||
|
||||
Reference in New Issue
Block a user