From 831b0e631406f726fc00452978ccf292158ae0ce Mon Sep 17 00:00:00 2001 From: MT Lewis Date: Thu, 18 Apr 2024 10:09:35 +0100 Subject: [PATCH] yarn-plugin: do not attempt to convert backstage: versions in peerDependencies Yarn does not support protocols other than npm and workspace for peerDependencies - any other protocols will produce an error and be converted to '*' when running yarn. This change matches that limitation in the beforeWorkspacePacking hook. Signed-off-by: MT Lewis --- .../yarn-plugin/src/handlers/beforeWorkspacePacking.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/yarn-plugin/src/handlers/beforeWorkspacePacking.ts b/packages/yarn-plugin/src/handlers/beforeWorkspacePacking.ts index e9f46a6159..b804f64226 100644 --- a/packages/yarn-plugin/src/handlers/beforeWorkspacePacking.ts +++ b/packages/yarn-plugin/src/handlers/beforeWorkspacePacking.ts @@ -38,13 +38,9 @@ export const beforeWorkspacePacking = async ( workspace: Workspace, rawManifest: any, ) => { - for (const dependencyType of [ - 'dependencies', - 'devDependencies', - 'peerDependencies', - ] as const) { - const backstageVersion = getCurrentBackstageVersion(); + const backstageVersion = getCurrentBackstageVersion(); + for (const dependencyType of ['dependencies', 'devDependencies'] as const) { const entries = Array.from( workspace.manifest.getForScope(dependencyType).values(), ).filter(descriptor => descriptor.range.startsWith(PROTOCOL));