From 5989919a0fb614aa3a262e2016e8f6fbe16378f3 Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Fri, 24 May 2024 17:24:24 -0400 Subject: [PATCH 1/9] remove tech radar icon from frontend due to removal of tech-radar plugin Signed-off-by: Dave Ashby --- .changeset/strange-flowers-burn.md | 5 +++++ .../default-app/packages/app/src/components/Root/Root.tsx | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 .changeset/strange-flowers-burn.md diff --git a/.changeset/strange-flowers-burn.md b/.changeset/strange-flowers-burn.md new file mode 100644 index 0000000000..6c875f1da9 --- /dev/null +++ b/.changeset/strange-flowers-burn.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Remove Tech-Radar menu from scaffolded app sidebar to align with backend removal of tech-radar plugin. diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 6768b48dad..58e795b8af 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -72,7 +72,6 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - From 1a212f989925d1e41f544c8e4d4cc45afdb9d219 Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Fri, 24 May 2024 17:43:45 -0400 Subject: [PATCH 2/9] Add changeset for tech radar menu removal from scaffolded app Signed-off-by: Dave Ashby --- .changeset/tall-bananas-reflect.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tall-bananas-reflect.md diff --git a/.changeset/tall-bananas-reflect.md b/.changeset/tall-bananas-reflect.md new file mode 100644 index 0000000000..00e8fd8b43 --- /dev/null +++ b/.changeset/tall-bananas-reflect.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Remove Tech Radar menu item from sidebar of scaffolded app to align with removal of tech-radar plugin from backend From 5bd18d59c8c0110278d2df9813fa9ea52b597bec Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Fri, 24 May 2024 17:54:53 -0400 Subject: [PATCH 3/9] remove duplicate changeset Signed-off-by: Dave Ashby --- .changeset/strange-flowers-burn.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/strange-flowers-burn.md diff --git a/.changeset/strange-flowers-burn.md b/.changeset/strange-flowers-burn.md deleted file mode 100644 index 6c875f1da9..0000000000 --- a/.changeset/strange-flowers-burn.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@backstage/create-app': patch ---- - -Remove Tech-Radar menu from scaffolded app sidebar to align with backend removal of tech-radar plugin. From df3c5351739d4e066ee35b6ac91e2b3343e47960 Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Fri, 24 May 2024 18:33:25 -0400 Subject: [PATCH 4/9] remove unnecessary Map Icon import Signed-off-by: Dave Ashby --- .../default-app/packages/app/src/components/Root/Root.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 58e795b8af..490b3fdb48 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -2,7 +2,6 @@ import React, { PropsWithChildren } from 'react'; import { makeStyles } from '@material-ui/core'; import HomeIcon from '@material-ui/icons/Home'; import ExtensionIcon from '@material-ui/icons/Extension'; -import MapIcon from '@material-ui/icons/MyLocation'; import LibraryBooks from '@material-ui/icons/LibraryBooks'; import CreateComponentIcon from '@material-ui/icons/AddCircleOutline'; import LogoFull from './LogoFull'; From b49897fc5e2310ef82ace4b0ac380eefc50916c6 Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Fri, 24 May 2024 18:43:41 -0400 Subject: [PATCH 5/9] address linting rule violation Signed-off-by: Dave Ashby --- .../default-app/packages/app/src/components/Root/Root.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 490b3fdb48..66bf3bb315 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -70,8 +70,7 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - - + From 600db9049ad2a9566972c4b1c007a224d7618f4f Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Wed, 29 May 2024 16:35:39 -0400 Subject: [PATCH 6/9] add comment to sidebar scroll wrapper div Signed-off-by: Dave Ashby --- .../default-app/packages/app/src/components/Root/Root.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 66bf3bb315..9efcd3b251 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -70,7 +70,9 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - + + { /* Items in this group will be scrollable if they run out of space */ } + From a77e6a436915e98176c2d7abd44cdcbea59ee268 Mon Sep 17 00:00:00 2001 From: Dave Ashby Date: Thu, 30 May 2024 18:45:31 -0400 Subject: [PATCH 7/9] tweak spacing Signed-off-by: Dave Ashby --- .../default-app/packages/app/src/components/Root/Root.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 9efcd3b251..430bb157fb 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -71,7 +71,7 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - { /* Items in this group will be scrollable if they run out of space */ } + { /* Items in this group will be scrollable if they run out of space */ } From abe7f872052c90565d3845626ea39ab8274cf4ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Mon, 3 Jun 2024 15:17:08 +0200 Subject: [PATCH 8/9] Update packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .../default-app/packages/app/src/components/Root/Root.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index 430bb157fb..cc2e27fb7c 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -71,7 +71,7 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - { /* Items in this group will be scrollable if they run out of space */ } + {/* Items in this group will be scrollable if they run out of space */} From e880508af0d73c91a110df5f499dfba96c9efcc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Wed, 5 Jun 2024 09:40:56 +0200 Subject: [PATCH 9/9] formatting MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .../default-app/packages/app/src/components/Root/Root.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx index cc2e27fb7c..71c04122ae 100644 --- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx +++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx @@ -71,7 +71,7 @@ export const Root = ({ children }: PropsWithChildren<{}>) => ( {/* End global nav */} - {/* Items in this group will be scrollable if they run out of space */} + {/* Items in this group will be scrollable if they run out of space */}