From 82148bbe09765b1604d28ea2e191dd5980be0221 Mon Sep 17 00:00:00 2001 From: Joon Park Date: Thu, 4 May 2023 10:35:12 +0100 Subject: [PATCH] Fix incorrect diffs in plugin author permission docs (#17439) Signed-off-by: Joon Park --- .../03-adding-a-resource-permission-check.md | 3 ++- .../04-authorizing-access-to-paginated-data.md | 8 ++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/permissions/plugin-authors/03-adding-a-resource-permission-check.md b/docs/permissions/plugin-authors/03-adding-a-resource-permission-check.md index 6b4ac98646..a4d51b64d0 100644 --- a/docs/permissions/plugin-authors/03-adding-a-resource-permission-check.md +++ b/docs/permissions/plugin-authors/03-adding-a-resource-permission-check.md @@ -31,11 +31,12 @@ export const todoListUpdatePermission = createPermission({ /* highlight-remove-next-line */ export const todoListPermissions = [todoListCreatePermission]; -/* highlight-add-next-line */ +/* highlight-add-start */ export const todoListPermissions = [ todoListCreatePermission, todoListUpdatePermission, ]; +/* highlight-add-end */ ``` Notice that unlike `todoListCreatePermission`, the `todoListUpdatePermission` permission contains a `resourceType` field. This field indicates to the permission framework that this permission is intended to be authorized in the context of a resource with type `'todo-item'`. You can use whatever string you like as the resource type, as long as you use the same value consistently for each type of resource. diff --git a/docs/permissions/plugin-authors/04-authorizing-access-to-paginated-data.md b/docs/permissions/plugin-authors/04-authorizing-access-to-paginated-data.md index 0cae08a668..a9e62040c5 100644 --- a/docs/permissions/plugin-authors/04-authorizing-access-to-paginated-data.md +++ b/docs/permissions/plugin-authors/04-authorizing-access-to-paginated-data.md @@ -66,16 +66,12 @@ export const todoListReadPermission = createPermission({ }); /* highlight-add-end */ -/* highlight-add-next-line */ -export const todoListPermissions = [ - todoListCreatePermission, - todoListUpdatePermission, -]; -/* highlight-add-next-line */ export const todoListPermissions = [ todoListCreatePermission, todoListUpdatePermission, + /* highlight-add-start */ todoListReadPermission, + /* highlight-add-end */ ]; ```