Address various comments round 1

Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-14 15:56:06 +00:00
parent 24dce3ca43
commit 816e0e04f9
7 changed files with 40 additions and 47 deletions
@@ -38,7 +38,12 @@ export class ServerPermissionClient extends PermissionClient {
    const { discoveryApi, configApi, serverTokenManager } = options;
    super({ discoveryApi, configApi });

-    if (this.enabled && !(serverTokenManager instanceof ServerTokenManager)) {
+    if (
+      this.enabled &&
+      // TODO: Find a cleaner way of ensuring usage of SERVER token manager when
+      // permissions are enabled.
+      serverTokenManager instanceof ServerTokenManager.noop().constructor
+    ) {
      throw new Error(
        'You must configure at least one key in backend.auth.keys if permissions are enabled.',
      );