Address various comments round 1

Signed-off-by: Joon Park <joonp@spotify.com>
This commit is contained in:
Joon Park
2021-12-14 15:56:06 +00:00
parent 24dce3ca43
commit 816e0e04f9
7 changed files with 40 additions and 47 deletions
+1
View File
@@ -32,6 +32,7 @@
"@backstage/core-components": "^0.8.0",
"@backstage/core-app-api": "^0.2.0",
"@backstage/core-plugin-api": "^0.3.0",
"@backstage/plugin-permission-react": "^0.1.1",
"@backstage/theme": "^0.2.14",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
@@ -61,7 +61,12 @@ import {
oidcAuthApiRef,
bitbucketAuthApiRef,
atlassianAuthApiRef,
identityApiRef,
} from '@backstage/core-plugin-api';
import {
permissionApiRef,
IdentityPermissionApi,
} from '@backstage/plugin-permission-react';
export const apis = [
createApiFactory({
@@ -296,4 +301,14 @@ export const apis = [
});
},
}),
createApiFactory({
api: permissionApiRef,
deps: {
discoveryApi: discoveryApiRef,
identityApi: identityApiRef,
configApi: configApiRef,
},
factory: ({ configApi, discoveryApi, identityApi }) =>
IdentityPermissionApi.create({ configApi, discoveryApi, identityApi }),
}),
];