fixes

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

packages/backend-tasks/src/setupTests.ts

@@ -14,4 +14,7 @@
  * limitations under the License.
  */
 
-export {};
+import { Settings } from 'luxon';
+
+// TS still thinks that methods can return null / placeholders, but we still want to throw as soon as possible when things go wrong
+Settings.throwOnInvalid = true;

packages/backend-tasks/src/tasks/PluginTaskSchedulerImpl.ts

@@ -112,9 +112,15 @@ export function parseDuration(
     return frequency.cron;
   }
 
-  if (Duration.isDuration(frequency)) {
-    return frequency.toISO();
+  const parsed = Duration.isDuration(frequency)
+    ? frequency
+    : Duration.fromObject(frequency);
+
+  if (!parsed.isValid) {
+    throw new Error(
+      `Invalid duration, ${parsed.invalidReason}: ${parsed.invalidExplanation}`,
+    );
   }
 
-  return Duration.fromObject(frequency).toISO();
+  return parsed.toISO()!;
 }

packages/backend-tasks/src/tasks/TaskWorker.test.ts

@@ -47,8 +47,8 @@ describe('TaskWorker', () => {
       const settings: TaskSettingsV2 = {
         version: 2,
         cadence: '*/2 * * * * *',
-        initialDelayDuration: Duration.fromObject({ seconds: 1 }).toISO(),
-        timeoutAfterDuration: Duration.fromObject({ minutes: 1 }).toISO(),
+        initialDelayDuration: Duration.fromObject({ seconds: 1 }).toISO()!,
+        timeoutAfterDuration: Duration.fromObject({ minutes: 1 }).toISO()!,
       };
 
       const worker = new TaskWorker('task1', fn, knex, logger);
@@ -131,7 +131,7 @@ describe('TaskWorker', () => {
         version: 2,
         initialDelayDuration: undefined,
         cadence: '* * * * * *',
-        timeoutAfterDuration: Duration.fromMillis(60000).toISO(),
+        timeoutAfterDuration: Duration.fromMillis(60000).toISO()!,
       };
       const checkFrequency = Duration.fromObject({ milliseconds: 100 });
       const worker = new TaskWorker('task1', fn, knex, logger, checkFrequency);
@@ -154,7 +154,7 @@ describe('TaskWorker', () => {
         version: 2,
         initialDelayDuration: undefined,
         cadence: '* * * * * *',
-        timeoutAfterDuration: Duration.fromMillis(60000).toISO(),
+        timeoutAfterDuration: Duration.fromMillis(60000).toISO()!,
       };
       const checkFrequency = Duration.fromObject({ milliseconds: 100 });
       const worker = new TaskWorker('task1', fn, knex, logger, checkFrequency);
@@ -179,7 +179,7 @@ describe('TaskWorker', () => {
         version: 2,
         initialDelayDuration: undefined,
         cadence: '* * * * * *',
-        timeoutAfterDuration: Duration.fromMillis(60000).toISO(),
+        timeoutAfterDuration: Duration.fromMillis(60000).toISO()!,
       };
 
       const worker = new TaskWorker('task1', fn, knex, logger);
@@ -235,7 +235,7 @@ describe('TaskWorker', () => {
         version: 2,
         initialDelayDuration: undefined,
         cadence: '* * * * * *',
-        timeoutAfterDuration: Duration.fromMillis(60000).toISO(),
+        timeoutAfterDuration: Duration.fromMillis(60000).toISO()!,
       };
 
       const worker1 = new TaskWorker('task1', fn, knex, logger);