From 3ab1b8fcae463674dc2c56640628ab224e44a6a1 Mon Sep 17 00:00:00 2001 From: Morgan Bentell Date: Tue, 21 Feb 2023 13:32:45 +0100 Subject: [PATCH 1/3] avoid wrapping addons when rendering them in a test setting, the levels of nesting is very sensitive due to TechDocsReaderPage.tsx, this will result in a more realistic component tree Signed-off-by: Morgan Bentell --- plugins/techdocs-addons-test-utils/src/test-utils.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/techdocs-addons-test-utils/src/test-utils.tsx b/plugins/techdocs-addons-test-utils/src/test-utils.tsx index 0d65e7e51e..53da924db5 100644 --- a/plugins/techdocs-addons-test-utils/src/test-utils.tsx +++ b/plugins/techdocs-addons-test-utils/src/test-utils.tsx @@ -236,9 +236,9 @@ export class TechDocsAddonTester { element={} > - {this.addons.map((addon, index) => ( - {addon} - ))} + {this.addons.map((addon, index) => + React.cloneElement(addon, { key: index }), + )} From 2b00d8a225c867a2c6d62a92d1d77a94b0a4ed2e Mon Sep 17 00:00:00 2001 From: Morgan Bentell Date: Tue, 21 Feb 2023 13:35:55 +0100 Subject: [PATCH 2/3] add changeset Signed-off-by: Morgan Bentell --- .changeset/quick-schools-dress.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/quick-schools-dress.md diff --git a/.changeset/quick-schools-dress.md b/.changeset/quick-schools-dress.md new file mode 100644 index 0000000000..511709461e --- /dev/null +++ b/.changeset/quick-schools-dress.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs-addons-test-utils': patch +--- + +Fix bug/problem with test helper From ab4e68032d4c76a21a87a5f72956ece29690b619 Mon Sep 17 00:00:00 2001 From: Morgan Bentell Date: Tue, 21 Feb 2023 13:50:08 +0100 Subject: [PATCH 3/3] remove unused import Signed-off-by: Morgan Bentell --- plugins/techdocs-addons-test-utils/src/test-utils.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/techdocs-addons-test-utils/src/test-utils.tsx b/plugins/techdocs-addons-test-utils/src/test-utils.tsx index 53da924db5..e60a96402c 100644 --- a/plugins/techdocs-addons-test-utils/src/test-utils.tsx +++ b/plugins/techdocs-addons-test-utils/src/test-utils.tsx @@ -14,7 +14,7 @@ * limitations under the License. */ -import React, { ReactElement, Fragment } from 'react'; +import React, { ReactElement } from 'react'; // Shadow DOM support for the simple and complete DOM testing utilities // https://github.com/testing-library/dom-testing-library/issues/742#issuecomment-674987855