From 8079f1f2d17c14a19b4c206dc2a9a4f61f53ace0 Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Tue, 13 Jul 2021 16:13:50 +0200 Subject: [PATCH 1/2] docs: add a docstring about the default healthcheck behavior Signed-off-by: Himanshu Mishra --- .../backend-common/src/service/createStatusCheckRouter.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/backend-common/src/service/createStatusCheckRouter.ts b/packages/backend-common/src/service/createStatusCheckRouter.ts index ab24a6953b..fd794cc9c4 100644 --- a/packages/backend-common/src/service/createStatusCheckRouter.ts +++ b/packages/backend-common/src/service/createStatusCheckRouter.ts @@ -22,6 +22,10 @@ import { errorHandler, statusCheckHandler, StatusCheck } from '../middleware'; export interface StatusCheckRouterOptions { logger: Logger; path?: string; + /** + * If not implemented, the default express middleware always returns 200. + * Override this to implement your own logic for a health check. + */ statusCheck?: StatusCheck; } From ad93bb0353ed7b1748874150338542bdd942162c Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Tue, 13 Jul 2021 16:26:13 +0200 Subject: [PATCH 2/2] backend-common: add a changeset for docstring update Signed-off-by: Himanshu Mishra --- .changeset/wise-rockets-smoke.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wise-rockets-smoke.md diff --git a/.changeset/wise-rockets-smoke.md b/.changeset/wise-rockets-smoke.md new file mode 100644 index 0000000000..c81d20519d --- /dev/null +++ b/.changeset/wise-rockets-smoke.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-common': patch +--- + +Document the default behavior of `statusCheck` option in `createStatusCheckRouter`.