Adjust to review comments

Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
This commit is contained in:
Oliver Sand
2021-11-02 09:58:11 +01:00
parent fe5738fe1c
commit 7e5bd18cf7
11 changed files with 60 additions and 32 deletions
+31 -13
View File
@@ -84,13 +84,19 @@ export const ApiTypeTitle: ({
apiEntity: ApiEntity;
}) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "AsyncApiDefinitionWidgetProps" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "AsyncApiDefinitionWidget" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const AsyncApiDefinitionWidget: ({
definition,
}: AsyncApiDefinitionWidgetProps) => JSX.Element;
export const AsyncApiDefinitionWidget: (
props: AsyncApiDefinitionWidgetProps,
) => JSX.Element;
// Warning: (ae-missing-release-tag) "AsyncApiDefinitionWidgetProps" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type AsyncApiDefinitionWidgetProps = {
definition: string;
};
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "ConsumedApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -171,22 +177,34 @@ export const EntityProvidingComponentsCard: ({
// @public (undocumented)
export const HasApisCard: ({ variant }: Props_3) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "OpenApiDefinitionWidgetProps" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "OpenApiDefinitionWidget" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const OpenApiDefinitionWidget: ({
definition,
}: OpenApiDefinitionWidgetProps) => JSX.Element;
export const OpenApiDefinitionWidget: (
props: OpenApiDefinitionWidgetProps,
) => JSX.Element;
// Warning: (ae-missing-release-tag) "OpenApiDefinitionWidgetProps" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type OpenApiDefinitionWidgetProps = {
definition: string;
};
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "PlainApiDefinitionWidget" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const PlainApiDefinitionWidget: ({
definition,
language,
}: Props_7) => JSX.Element;
export const PlainApiDefinitionWidget: (
props: PlainApiDefinitionWidgetProps,
) => JSX.Element;
// Warning: (ae-missing-release-tag) "PlainApiDefinitionWidgetProps" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type PlainApiDefinitionWidgetProps = {
definition: any;
language: string;
};
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "ProvidedApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -29,12 +29,12 @@ export type AsyncApiDefinitionWidgetProps = {
definition: string;
};
export const AsyncApiDefinitionWidget = ({
definition,
}: AsyncApiDefinitionWidgetProps) => {
export const AsyncApiDefinitionWidget = (
props: AsyncApiDefinitionWidgetProps,
) => {
return (
<Suspense fallback={<Progress />}>
<LazyAsyncApiDefinition definition={definition} />
<LazyAsyncApiDefinition {...props} />
</Suspense>
);
};
@@ -15,3 +15,4 @@
*/
export { AsyncApiDefinitionWidget } from './AsyncApiDefinitionWidget';
export type { AsyncApiDefinitionWidgetProps } from './AsyncApiDefinitionWidget';
@@ -29,12 +29,12 @@ export type GraphQlDefinitionWidgetProps = {
definition: string;
};
export const GraphQlDefinitionWidget = ({
definition,
}: GraphQlDefinitionWidgetProps) => {
export const GraphQlDefinitionWidget = (
props: GraphQlDefinitionWidgetProps,
) => {
return (
<Suspense fallback={<Progress />}>
<LazyGraphQlDefinition definition={definition} />
<LazyGraphQlDefinition {...props} />
</Suspense>
);
};
@@ -15,3 +15,4 @@
*/
export { GraphQlDefinitionWidget } from './GraphQlDefinitionWidget';
export type { GraphQlDefinitionWidgetProps } from './GraphQlDefinitionWidget';
@@ -29,12 +29,12 @@ export type OpenApiDefinitionWidgetProps = {
definition: string;
};
export const OpenApiDefinitionWidget = ({
definition,
}: OpenApiDefinitionWidgetProps) => {
export const OpenApiDefinitionWidget = (
props: OpenApiDefinitionWidgetProps,
) => {
return (
<Suspense fallback={<Progress />}>
<LazyOpenApiDefinition definition={definition} />
<LazyOpenApiDefinition {...props} />
</Suspense>
);
};
@@ -15,3 +15,4 @@
*/
export { OpenApiDefinitionWidget } from './OpenApiDefinitionWidget';
export type { OpenApiDefinitionWidgetProps } from './OpenApiDefinitionWidget';
@@ -17,13 +17,19 @@
import React from 'react';
import { CodeSnippet } from '@backstage/core-components';
type Props = {
export type PlainApiDefinitionWidgetProps = {
definition: any;
language: string;
};
export const PlainApiDefinitionWidget = ({ definition, language }: Props) => {
export const PlainApiDefinitionWidget = (
props: PlainApiDefinitionWidgetProps,
) => {
return (
<CodeSnippet text={definition} language={language} showCopyCodeButton />
<CodeSnippet
text={props.definition}
language={props.language}
showCopyCodeButton
/>
);
};
@@ -15,3 +15,4 @@
*/
export { PlainApiDefinitionWidget } from './PlainApiDefinitionWidget';
export type { PlainApiDefinitionWidgetProps } from './PlainApiDefinitionWidget';