From 7db0ffb6e5c4217ecbcc2cc586e7ee8685cbbd7a Mon Sep 17 00:00:00 2001
From: Marvin9 <marvinduff97@gmail.com>
Date: Tue, 6 Oct 2020 21:19:31 +0530
Subject: [PATCH] feat: add rel to <a> & few <Link> tags

---
 .../core/src/layout/ErrorPage/ErrorPage.tsx   |  7 ++++++-
 .../reader/components/TechDocsPageHeader.tsx  |  6 +++++-
 .../components/WelcomePage/WelcomePage.tsx    | 20 +++++++++++++++----
 3 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/packages/core/src/layout/ErrorPage/ErrorPage.tsx b/packages/core/src/layout/ErrorPage/ErrorPage.tsx
index 71a24652ba..3d80955cc9 100644
--- a/packages/core/src/layout/ErrorPage/ErrorPage.tsx
+++ b/packages/core/src/layout/ErrorPage/ErrorPage.tsx
@@ -65,7 +65,12 @@ export const ErrorPage = ({
             Go back
           </Link>
           ... or if you think this is a bug, please file an{' '}
-          <Link href="https://github.com/spotify/backstage/issues">issue.</Link>
+          <Link
+            href="https://github.com/spotify/backstage/issues"
+            rel="noopener noreferrer"
+          >
+            issue.
+          </Link>
         </Typography>
       </Grid>
     </Grid>
diff --git a/plugins/techdocs/src/reader/components/TechDocsPageHeader.tsx b/plugins/techdocs/src/reader/components/TechDocsPageHeader.tsx
index b01ace4994..8084378ca1 100644
--- a/plugins/techdocs/src/reader/components/TechDocsPageHeader.tsx
+++ b/plugins/techdocs/src/reader/components/TechDocsPageHeader.tsx
@@ -66,7 +66,11 @@ export const TechDocsPageHeader = ({
         <HeaderLabel
           label=""
           value={
-            <a href={locationMetadata.target} target="_blank">
+            <a
+              href={locationMetadata.target}
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <GitHubIcon style={{ marginTop: '-25px', fill: '#fff' }} />
             </a>
           }
diff --git a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx
index 3ceb0af58d..1afdb53ad4 100644
--- a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx
+++ b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx
@@ -69,7 +69,10 @@ const WelcomePage = () => {
                   the project and we have already begun work on various aspects
                   of these phases. The best way to keep track of the progress is
                   through the&nbsp;
-                  <Link href="https://github.com/spotify/backstage/milestones">
+                  <Link
+                    href="https://github.com/spotify/backstage/milestones"
+                    rel="noopener noreferrer"
+                  >
                     Milestones
                   </Link>
                   .
@@ -113,7 +116,10 @@ const WelcomePage = () => {
               </Typography>
               <Typography variant="body1" paragraph>
                 We suggest you either check out the documentation for{' '}
-                <Link href="https://github.com/spotify/backstage/blob/master/docs/plugins/create-a-plugin.md">
+                <Link
+                  href="https://github.com/spotify/backstage/blob/master/docs/plugins/create-a-plugin.md"
+                  rel="noopener noreferrer"
+                >
                   creating a plugin
                 </Link>{' '}
                 or have a look in the code for the{' '}
@@ -121,7 +127,10 @@ const WelcomePage = () => {
                   existing plugins
                 </Link>{' '}
                 in the directory{' '}
-                <Link href="https://github.com/spotify/backstage/tree/master/plugins">
+                <Link
+                  href="https://github.com/spotify/backstage/tree/master/plugins"
+                  rel="noopener noreferrer"
+                >
                   <code>plugins/</code>
                 </Link>
                 .
@@ -135,7 +144,10 @@ const WelcomePage = () => {
                   <Link href="https://backstage.io">backstage.io</Link>
                 </ListItem>
                 <ListItem>
-                  <Link href="https://github.com/spotify/backstage/blob/master/docs/plugins/create-a-plugin.md">
+                  <Link
+                    href="https://github.com/spotify/backstage/blob/master/docs/plugins/create-a-plugin.md"
+                    rel="noopener noreferrer"
+                  >
                     Create a plugin
                   </Link>
                 </ListItem>