From 7dacc9b863ef7002a21bc794dbe59e50aba407ee Mon Sep 17 00:00:00 2001 From: Tejas Kumar Date: Wed, 16 Jun 2021 10:15:25 +0200 Subject: [PATCH] Make Slack URL an example and fallback if no href Signed-off-by: Tejas Kumar --- .../src/layout/ErrorBoundary/ErrorBoundary.tsx | 18 +++++++++++------- packages/core/src/layout/constants.ts | 12 +++++++++--- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/packages/core-components/src/layout/ErrorBoundary/ErrorBoundary.tsx b/packages/core-components/src/layout/ErrorBoundary/ErrorBoundary.tsx index 189803de59..5ecbf7b723 100644 --- a/packages/core-components/src/layout/ErrorBoundary/ErrorBoundary.tsx +++ b/packages/core-components/src/layout/ErrorBoundary/ErrorBoundary.tsx @@ -67,13 +67,17 @@ const Error = ({ slackChannel, error }: EProps) => { {slackChannel && (

Please contact{' '} - - {slackChannel.name} - {' '} + {slackChannel.href ? ( + + {slackChannel.name} + + ) : ( + slackChannel.name + )}{' '} for help.

)} diff --git a/packages/core/src/layout/constants.ts b/packages/core/src/layout/constants.ts index a7005fc5ce..0b469d9cd3 100644 --- a/packages/core/src/layout/constants.ts +++ b/packages/core/src/layout/constants.ts @@ -13,7 +13,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -export const slackChannel = { - name: '#backstage', - href: 'https://spotify.slack.com/archives/C54P1J36Z', + +type SlackChannel = { + name: string; + href?: string; +}; + +export const slackChannel: SlackChannel = { + name: '#backstage', + href: 'https://slack.com/channels/your-channel', };