chore: safer way to do redactions

Signed-off-by: blam <ben@blam.sh>

packages/backend-app-api/package.json

@@ -72,6 +72,7 @@
     "fs-extra": "^11.2.0",
     "helmet": "^6.0.0",
     "jose": "^5.0.0",
+    "json-stringify-safe": "^5.0.1",
     "knex": "^3.0.0",
     "lodash": "^4.17.21",
     "logform": "^2.3.2",
@@ -93,6 +94,7 @@
     "@types/compression": "^1.7.0",
     "@types/fs-extra": "^11.0.0",
     "@types/http-errors": "^2.0.0",
+    "@types/json-stringify-safe": "^5.0.3",
     "@types/minimist": "^1.2.0",
     "@types/morgan": "^1.9.0",
     "@types/node-forge": "^1.3.0",

packages/backend-app-api/src/logging/WinstonLogger.ts

@@ -27,6 +27,7 @@ import {
   transports,
   transport as Transport,
 } from 'winston';
+import stringify from 'json-stringify-safe';
 import { escapeRegExp } from '../lib/escapeRegExp';
 
 /**
@@ -86,9 +87,13 @@ export class WinstonLogger implements RootLoggerService {
     let redactionPattern: RegExp | undefined = undefined;
 
     const replace = (obj: TransformableInfo) => {
-      const stringifiedFields = JSON.stringify(obj, null);
+      if (!redactionPattern) {
+        return obj;
+      }
+
+      const stringifiedFields = stringify(obj);
       const redacted = JSON.parse(
-        stringifiedFields.replace(redactionPattern!, '[REDACTED]'),
+        stringifiedFields.replace(redactionPattern, '[REDACTED]'),
       );
 
       for (const key in redacted) {