From 7c55fae20872d74e65fcaf3ad8909f6c53665105 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 17 Nov 2021 20:34:46 +0100
Subject: [PATCH] chore: code review comments and renaming some ids for
 routeRefs

Signed-off-by: blam <ben@blam.sh>
---
 plugins/catalog-react/src/routes.ts   | 2 +-
 plugins/cost-insights/src/plugin.ts   | 4 ++--
 plugins/gcp-projects/src/routes.ts    | 4 ++--
 plugins/gitops-profiles/src/routes.ts | 2 +-
 plugins/jenkins/src/plugin.ts         | 2 +-
 plugins/lighthouse/src/plugin.ts      | 6 +++---
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/plugins/catalog-react/src/routes.ts b/plugins/catalog-react/src/routes.ts
index bb19b6c312..73c44d1a4a 100644
--- a/plugins/catalog-react/src/routes.ts
+++ b/plugins/catalog-react/src/routes.ts
@@ -25,7 +25,7 @@ export const rootRoute = createRouteRef({
 export const catalogRouteRef = rootRoute;
 
 export const entityRoute = createRouteRef({
-  id: 'catalog/entity',
+  id: 'catalog-entity',
   params: ['namespace', 'kind', 'name'],
 });
 
diff --git a/plugins/cost-insights/src/plugin.ts b/plugins/cost-insights/src/plugin.ts
index 884e458418..4c37cd7531 100644
--- a/plugins/cost-insights/src/plugin.ts
+++ b/plugins/cost-insights/src/plugin.ts
@@ -25,11 +25,11 @@ export const rootRouteRef = createRouteRef({
 });
 
 export const projectGrowthAlertRef = createRouteRef({
-  id: 'cost-insights/investigating-growth',
+  id: 'cost-insights-investigating-growth',
 });
 
 export const unlabeledDataflowAlertRef = createRouteRef({
-  id: 'cost-insights/labeling-jobs',
+  id: 'cost-insights-labeling-jobs',
 });
 
 export const costInsightsPlugin = createPlugin({
diff --git a/plugins/gcp-projects/src/routes.ts b/plugins/gcp-projects/src/routes.ts
index de4c39fb7d..2429f12cae 100644
--- a/plugins/gcp-projects/src/routes.ts
+++ b/plugins/gcp-projects/src/routes.ts
@@ -20,8 +20,8 @@ export const rootRouteRef = createRouteRef({
   id: 'gcp-projects',
 });
 export const projectRouteRef = createRouteRef({
-  id: 'gcp-projects/project',
+  id: 'gcp-projects-project',
 });
 export const newProjectRouteRef = createRouteRef({
-  id: 'gcp-projects/new',
+  id: 'gcp-projects-new',
 });
diff --git a/plugins/gitops-profiles/src/routes.ts b/plugins/gitops-profiles/src/routes.ts
index 0a100c8215..8ee9612be0 100644
--- a/plugins/gitops-profiles/src/routes.ts
+++ b/plugins/gitops-profiles/src/routes.ts
@@ -21,7 +21,7 @@ export const gitOpsClusterListRoute = createRouteRef({
 });
 
 export const gitOpsClusterDetailsRoute = createRouteRef({
-  id: 'gitops-cluster/:owner/:repo',
+  id: 'gitops-cluster-details',
   params: ['owner', 'repo'],
 });
 
diff --git a/plugins/jenkins/src/plugin.ts b/plugins/jenkins/src/plugin.ts
index e38cf55f54..c32c9b50d1 100644
--- a/plugins/jenkins/src/plugin.ts
+++ b/plugins/jenkins/src/plugin.ts
@@ -31,7 +31,7 @@ export const rootRouteRef = createRouteRef({
 });
 
 export const buildRouteRef = createSubRouteRef({
-  id: 'jenkins/build',
+  id: 'jenkins/builds',
   path: '/builds/:jobFullName/:buildNumber',
   parent: rootRouteRef,
 });
diff --git a/plugins/lighthouse/src/plugin.ts b/plugins/lighthouse/src/plugin.ts
index e5274204e2..4ce7cc62b5 100644
--- a/plugins/lighthouse/src/plugin.ts
+++ b/plugins/lighthouse/src/plugin.ts
@@ -29,15 +29,15 @@ export const rootRouteRef = createRouteRef({
 });
 
 export const viewAuditRouteRef = createRouteRef({
-  id: 'audit/:id',
+  id: 'lighthouse-audit',
 });
 
 export const createAuditRouteRef = createRouteRef({
-  id: 'create-audit',
+  id: 'lighthouse-create-audit',
 });
 
 export const entityContentRouteRef = createRouteRef({
-  id: 'entity-content',
+  id: 'lighthouse-entity-content',
 });
 
 export const lighthousePlugin = createPlugin({