From 776daa18c5486681de430fd31f5e6e6fe1f08116 Mon Sep 17 00:00:00 2001 From: Jaan Jahilo Date: Sat, 22 Apr 2023 17:16:03 +0300 Subject: [PATCH 1/6] Use permalinks in datadog-rum/installation.md Signed-off-by: Jaan Jahilo --- docs/integrations/datadog-rum/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/integrations/datadog-rum/installation.md b/docs/integrations/datadog-rum/installation.md index 821d35db15..32eb2b3de8 100644 --- a/docs/integrations/datadog-rum/installation.md +++ b/docs/integrations/datadog-rum/installation.md @@ -24,7 +24,7 @@ app: # env: 'staging' ``` -If your [`app-config.yaml`](https://github.com/backstage/backstage/blob/master/app-config.yaml#L5) file does not have this configuration, you may have to adjust your [`packages/app/public/index.html`](https://github.com/backstage/backstage/blob/master/packages/app/public/index.html#L64) to include the Datadog RUM `init()` section manually. +If your [`app-config.yaml`](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/app-config.yaml#L5) file does not have this configuration, you may have to adjust your [`packages/app/public/index.html`](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/packages/app/public/index.html#L69) to include the Datadog RUM `init()` section manually. The `clientToken` and `applicationId` are generated from the Datadog RUM page following From 24190f903fa19984af34802935d8ab808e7e0452 Mon Sep 17 00:00:00 2001 From: Jaan Jahilo Date: Sat, 22 Apr 2023 17:16:50 +0300 Subject: [PATCH 2/6] Use permalinks in plugins/cost-insights/contrib/aws-cost-explorer-api.md Signed-off-by: Jaan Jahilo --- plugins/cost-insights/contrib/aws-cost-explorer-api.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/cost-insights/contrib/aws-cost-explorer-api.md b/plugins/cost-insights/contrib/aws-cost-explorer-api.md index 1e3f4e9de6..4fbf8a0cbe 100644 --- a/plugins/cost-insights/contrib/aws-cost-explorer-api.md +++ b/plugins/cost-insights/contrib/aws-cost-explorer-api.md @@ -75,7 +75,7 @@ try { We can use the data provided by the Cost Explorer API to implement CostInsightsApi methods such as `getGroupDailyCost`, `getProjectDailyCost`, and `getProductInsights`. You'll still need to provide external data for methods such as `getUserGroups` and `getAlerts`. -### 1. [getGroupDailyCost](https://github.com/backstage/backstage/blob/master/plugins/cost-insights/src/api/CostInsightsApi.ts#L93) +### 1. [getGroupDailyCost](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/cost-insights/src/api/CostInsightsApi.ts#L119) The `getGroupDailyCost` method is expected to return daily cost aggregations for a given group and interval time frame as a [`Cost`](https://github.com/backstage/backstage/blob/master/plugins/cost-insights-common/src/types/Cost.ts). @@ -206,13 +206,13 @@ Sample `groupedCosts` based on the response: } ``` -### 2. [getProjectDailyCost](https://github.com/backstage/backstage/blob/master/plugins/cost-insights/src/api/CostInsightsApi.ts#L111) +### 2. [getProjectDailyCost](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/cost-insights/src/api/CostInsightsApi.ts#L137) The `getProjectDailyCost` method is expected to return daily cost aggregations for a given billing entity and interval time frame as a [`Cost`](https://github.com/backstage/backstage/blob/master/plugins/cost-insights-common/src/types/Cost.ts). This should be similar to the `getGroupDailyCost` method implementation, but with an updated `LINKED_ACCOUNT` filter to get narrower cost data for a lower-level linked account. -### 3. [getProductInsights](https://github.com/backstage/backstage/blob/master/plugins/cost-insights/src/api/CostInsightsApi.ts#L111) +### 3. [getProductInsights](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/cost-insights/src/api/CostInsightsApi.ts#L165) The `getProductInsights` method is expected to return cost aggregations for a particular cloud product and interval time frame as an [`Entity`](https://github.com/backstage/backstage/blob/master/plugins/cost-insights-common/src/types/Entity.ts). From 2e19fca42b21519bd6d15acd177057e200178aab Mon Sep 17 00:00:00 2001 From: Jaan Jahilo Date: Sat, 22 Apr 2023 17:18:13 +0300 Subject: [PATCH 3/6] Use permalink in packages/backend-openapi-utils/README.md Signed-off-by: Jaan Jahilo --- packages/backend-openapi-utils/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend-openapi-utils/README.md b/packages/backend-openapi-utils/README.md index 51455ccccb..e5f1ae922c 100644 --- a/packages/backend-openapi-utils/README.md +++ b/packages/backend-openapi-utils/README.md @@ -42,4 +42,4 @@ Router() as ApiRouter> ### Runtime validation -Using a package like [`express-openapi-validator`](https://www.npmjs.com/package/express-openapi-validator), would allow us to remove [validation of request bodies with `AJV`](https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/src/service/util.ts#L58). However, `AJV` currently doesn't have support for OpenAPI 3.1 and `express-openapi-validator` enforces full URL matching for paths, meaning it cannot be mounted at the router level. +Using a package like [`express-openapi-validator`](https://www.npmjs.com/package/express-openapi-validator), would allow us to remove [validation of request bodies with `AJV`](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/catalog-backend/src/service/util.ts#L58). However, `AJV` currently doesn't have support for OpenAPI 3.1 and `express-openapi-validator` enforces full URL matching for paths, meaning it cannot be mounted at the router level. From e9acefd222c3da2ea0b97e526c3c5a391d31d2ef Mon Sep 17 00:00:00 2001 From: Jaan Jahilo Date: Sat, 22 Apr 2023 17:20:41 +0300 Subject: [PATCH 4/6] Use permalinks in packages/create-app/CHANGELOG.md Signed-off-by: Jaan Jahilo --- packages/create-app/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/create-app/CHANGELOG.md b/packages/create-app/CHANGELOG.md index a28042cc3d..fb6be56ae2 100644 --- a/packages/create-app/CHANGELOG.md +++ b/packages/create-app/CHANGELOG.md @@ -2581,7 +2581,7 @@ fields that clarify a previous grey area such that the intent of the alteration is made explicit. This is caught by `tsc` and your editor if you are using the `@ts-check` and `@param` syntax in your migration files - ([example](https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/migrations/20220116144621_remove_legacy.js#L17)), + ([example](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/catalog-backend/migrations/20220116144621_remove_legacy.js#L17)), which we strongly recommend. See the [`knex` documentation](https://knexjs.org/#Schema-alter) for more @@ -2651,7 +2651,7 @@ fields that clarify a previous grey area such that the intent of the alteration is made explicit. This is caught by `tsc` and your editor if you are using the `@ts-check` and `@param` syntax in your migration files - ([example](https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/migrations/20220116144621_remove_legacy.js#L17)), + ([example](https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/catalog-backend/migrations/20220116144621_remove_legacy.js#L17)), which we strongly recommend. See the [`knex` documentation](https://knexjs.org/#Schema-alter) for more From fe16bd39e830323f24589501b1cca83f5242a6e3 Mon Sep 17 00:00:00 2001 From: Jaan Jahilo Date: Sat, 22 Apr 2023 17:33:17 +0300 Subject: [PATCH 5/6] Add changeset file for changes Signed-off-by: Jaan Jahilo --- .changeset/chilled-pants-wonder.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/chilled-pants-wonder.md diff --git a/.changeset/chilled-pants-wonder.md b/.changeset/chilled-pants-wonder.md new file mode 100644 index 0000000000..5ec922099c --- /dev/null +++ b/.changeset/chilled-pants-wonder.md @@ -0,0 +1,7 @@ +--- +'@backstage/backend-openapi-utils': patch +'@backstage/plugin-cost-insights': patch +'@backstage/create-app': patch +--- + +Use permalinks for links including a line number reference From ed13f75823492b346fb89a2ff472d9416bc25084 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 4 May 2023 15:08:59 +0200 Subject: [PATCH 6/6] Update .changeset/chilled-pants-wonder.md Signed-off-by: Patrik Oldsberg --- .changeset/chilled-pants-wonder.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.changeset/chilled-pants-wonder.md b/.changeset/chilled-pants-wonder.md index 5ec922099c..501ced7cba 100644 --- a/.changeset/chilled-pants-wonder.md +++ b/.changeset/chilled-pants-wonder.md @@ -1,7 +1,5 @@ --- '@backstage/backend-openapi-utils': patch -'@backstage/plugin-cost-insights': patch -'@backstage/create-app': patch --- Use permalinks for links including a line number reference