From 7b407b303b83d28e9973c58dad618cfa36357d50 Mon Sep 17 00:00:00 2001 From: Mitchell Hentges Date: Thu, 29 Dec 2022 15:59:26 -0800 Subject: [PATCH] Use both variables in cli's "base url conflict" error message `appBaseUrl` was specified twice - which _is_ fine, because the two values were already proven equal - but it took me until writing this commit message to realize that it isn't a bug. So, I'd advocate for this change as "ease of understanding" improvement :) Signed-off-by: Mitchell Hentges --- .changeset/forty-mangos-fail.md | 5 +++++ packages/cli/src/commands/start/startFrontend.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/forty-mangos-fail.md diff --git a/.changeset/forty-mangos-fail.md b/.changeset/forty-mangos-fail.md new file mode 100644 index 0000000000..d86d9c0e56 --- /dev/null +++ b/.changeset/forty-mangos-fail.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Slightly improve readability of "base URL conflict" error handling code diff --git a/packages/cli/src/commands/start/startFrontend.ts b/packages/cli/src/commands/start/startFrontend.ts index b7b81e6bff..991439c010 100644 --- a/packages/cli/src/commands/start/startFrontend.ts +++ b/packages/cli/src/commands/start/startFrontend.ts @@ -80,7 +80,7 @@ export async function startFrontend(options: StartAppOptions) { `⚠️ Conflict between app baseUrl and backend baseUrl: app.baseUrl: ${appBaseUrl} - backend.baseUrl: ${appBaseUrl} + backend.baseUrl: ${backendBaseUrl} Must have unique hostname and/or ports.