From 7b133cd34ce64250106dbaec00c349331ced1749 Mon Sep 17 00:00:00 2001 From: blam Date: Fri, 25 Feb 2022 17:37:11 +0100 Subject: [PATCH] chore: reworking the types to be a little more user friendly Signed-off-by: blam --- .../src/next/TemplateListPage/TemplateGroup.tsx | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/plugins/scaffolder/src/next/TemplateListPage/TemplateGroup.tsx b/plugins/scaffolder/src/next/TemplateListPage/TemplateGroup.tsx index 8af551d562..389ec83231 100644 --- a/plugins/scaffolder/src/next/TemplateListPage/TemplateGroup.tsx +++ b/plugins/scaffolder/src/next/TemplateListPage/TemplateGroup.tsx @@ -27,19 +27,14 @@ import { stringifyEntityRef } from '@backstage/catalog-model'; export interface TemplateGroupProps { templates: TemplateEntityV1beta3[]; - title?: string; + title: React.ReactNode; components?: { - titleComponent?: React.ReactNode; CardComponent?: React.ComponentType; }; } export const TemplateGroup = (props: TemplateGroupProps) => { - const { - templates, - title, - components: { titleComponent, CardComponent } = {}, - } = props; + const { templates, title, components: { CardComponent } = {} } = props; if (templates.length === 0) { return ( @@ -53,13 +48,14 @@ export const TemplateGroup = (props: TemplateGroupProps) => { ); } - const titleFragment = titleComponent || ; + const titleComponent = + typeof title === 'string' ? : title; const Card = CardComponent || TemplateCard; return ( - {titleFragment} + {titleComponent} {templates.map(template => (