From 7acc18e21a7911b668e201abc7dfe2acc29087f6 Mon Sep 17 00:00:00 2001
From: therynamo <theryn.groetken@gemini.com>
Date: Wed, 3 Nov 2021 14:38:57 -0500
Subject: [PATCH] feat: Allow SSE on AWS S3 Buckets

Signed-off-by: therynamo <theryn.groetken@gemini.com>
---
 .changeset/orange-cougars-relax.md                   |  5 +++++
 docs/features/techdocs/configuration.md              |  5 +++++
 .../techdocs-common/src/stages/publish/awsS3.test.ts | 10 ++++++++++
 packages/techdocs-common/src/stages/publish/awsS3.ts | 12 +++++++++++-
 4 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/orange-cougars-relax.md

diff --git a/.changeset/orange-cougars-relax.md b/.changeset/orange-cougars-relax.md
new file mode 100644
index 0000000000..2f55e23220
--- /dev/null
+++ b/.changeset/orange-cougars-relax.md
@@ -0,0 +1,5 @@
+---
+'@backstage/techdocs-common': patch
+---
+
+Allow aws s3 buckets to pass an sse configuration so they can publish to encrypted buckets
diff --git a/docs/features/techdocs/configuration.md b/docs/features/techdocs/configuration.md
index fbe9f36540..cfc522adf6 100644
--- a/docs/features/techdocs/configuration.md
+++ b/docs/features/techdocs/configuration.md
@@ -106,6 +106,11 @@ techdocs:
       # This allows providers like LocalStack, Minio and Wasabi (and possibly others) to be used to host tech docs.
       s3ForcePathStyle: false
 
+      # (Optional) AWS Server Side Encryption
+      # If not set, encrypted buckets will fail to publish.
+      # https://docs.aws.amazon.com/AmazonS3/latest/userguide/specifying-s3-encryption.html
+      sse: 'aws:kms' # or AES256
+
     # Required when techdocs.publisher.type is set to 'azureBlobStorage'. Skip otherwise.
 
     azureBlobStorage:
diff --git a/packages/techdocs-common/src/stages/publish/awsS3.test.ts b/packages/techdocs-common/src/stages/publish/awsS3.test.ts
index 1f7afa0855..ff88f12939 100644
--- a/packages/techdocs-common/src/stages/publish/awsS3.test.ts
+++ b/packages/techdocs-common/src/stages/publish/awsS3.test.ts
@@ -45,10 +45,12 @@ const createPublisherFromConfig = ({
   bucketName = 'bucketName',
   bucketRootPath = '/',
   legacyUseCaseSensitiveTripletPaths = false,
+  sse,
 }: {
   bucketName?: string;
   bucketRootPath?: string;
   legacyUseCaseSensitiveTripletPaths?: boolean;
+  sse?: string;
 } = {}) => {
   const mockConfig = new ConfigReader({
     techdocs: {
@@ -62,6 +64,7 @@ const createPublisherFromConfig = ({
           },
           bucketName,
           bucketRootPath,
+          sse,
         },
       },
       legacyUseCaseSensitiveTripletPaths,
@@ -171,6 +174,13 @@ describe('AwsS3Publish', () => {
       expect(await publisher.publish({ entity, directory })).toBeUndefined();
     });
 
+    it('should publish a directory when sse is specified', async () => {
+      const publisher = createPublisherFromConfig({
+        sse: 'aws:kms',
+      });
+      expect(await publisher.publish({ entity, directory })).toBeUndefined();
+    });
+
     it('should fail to publish a directory', async () => {
       const wrongPathToGeneratedDirectory = path.join(
         rootDir,
diff --git a/packages/techdocs-common/src/stages/publish/awsS3.ts b/packages/techdocs-common/src/stages/publish/awsS3.ts
index 5ebc2aab77..05ce80eaca 100644
--- a/packages/techdocs-common/src/stages/publish/awsS3.ts
+++ b/packages/techdocs-common/src/stages/publish/awsS3.ts
@@ -62,6 +62,7 @@ export class AwsS3Publish implements PublisherBase {
   private readonly legacyPathCasing: boolean;
   private readonly logger: Logger;
   private readonly bucketRootPath: string;
+  private readonly sse?: 'aws:kms' | 'AES256';
 
   constructor(options: {
     storageClient: aws.S3;
@@ -75,6 +76,7 @@ export class AwsS3Publish implements PublisherBase {
     this.legacyPathCasing = options.legacyPathCasing;
     this.logger = options.logger;
     this.bucketRootPath = options.bucketRootPath;
+    this.sse = sse;
   }
 
   static fromConfig(config: Config, logger: Logger): PublisherBase {
@@ -92,6 +94,11 @@ export class AwsS3Publish implements PublisherBase {
       config.getOptionalString('techdocs.publisher.awsS3.bucketRootPath') || '',
     );
 
+    const sse = config.getOptionalString('techdocs.publisher.awsS3.sse') as
+      | 'aws:kms'
+      | 'AES256'
+      | undefined;
+
     // Credentials is an optional config. If missing, the default ways of authenticating AWS SDK V2 will be used.
     // 1. AWS environment variables
     // https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html
@@ -138,6 +145,7 @@ export class AwsS3Publish implements PublisherBase {
       bucketRootPath,
       legacyPathCasing,
       logger,
+      sse,
     });
   }
 
@@ -208,6 +216,7 @@ export class AwsS3Publish implements PublisherBase {
   async publish({ entity, directory }: PublishRequest): Promise<void> {
     const useLegacyPathCasing = this.legacyPathCasing;
     const bucketRootPath = this.bucketRootPath;
+    const sse = this.sse;
 
     // First, try to retrieve a list of all individual files currently existing
     let existingFiles: string[] = [];
@@ -250,7 +259,8 @@ export class AwsS3Publish implements PublisherBase {
               bucketRootPath,
             ),
             Body: fileStream,
-          };
+            ...(sse && { ServerSideEncryption: sse }),
+          } as aws.S3.PutObjectRequest;
 
           return this.storageClient.upload(params).promise();
         },