From 7aae8e302e54a6e0eb5a019be2ac4ba4c97cc46b Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 17 Oct 2024 17:38:47 +0200 Subject: [PATCH] backend-test-utils: fix discovery mock factory Signed-off-by: Patrik Oldsberg --- .changeset/selfish-ads-count.md | 5 +++++ .../src/next/services/mockServices.ts | 12 +++++++----- 2 files changed, 12 insertions(+), 5 deletions(-) create mode 100644 .changeset/selfish-ads-count.md diff --git a/.changeset/selfish-ads-count.md b/.changeset/selfish-ads-count.md new file mode 100644 index 0000000000..2f2f0597dd --- /dev/null +++ b/.changeset/selfish-ads-count.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-test-utils': patch +--- + +The `mockServices.discovery.factory()` factory now uses the mocked discovery service as its implementation, avoid the need for configuration. diff --git a/packages/backend-test-utils/src/next/services/mockServices.ts b/packages/backend-test-utils/src/next/services/mockServices.ts index 789b75de9d..55632f4734 100644 --- a/packages/backend-test-utils/src/next/services/mockServices.ts +++ b/packages/backend-test-utils/src/next/services/mockServices.ts @@ -16,10 +16,7 @@ import { cacheServiceFactory } from '@backstage/backend-defaults/cache'; import { databaseServiceFactory } from '@backstage/backend-defaults/database'; -import { - HostDiscovery, - discoveryServiceFactory, -} from '@backstage/backend-defaults/discovery'; +import { HostDiscovery } from '@backstage/backend-defaults/discovery'; import { httpRouterServiceFactory } from '@backstage/backend-defaults/httpRouter'; import { lifecycleServiceFactory } from '@backstage/backend-defaults/lifecycle'; import { loggerServiceFactory } from '@backstage/backend-defaults/logger'; @@ -273,7 +270,12 @@ export namespace mockServices { ); } export namespace discovery { - export const factory = () => discoveryServiceFactory; + export const factory = () => + createServiceFactory({ + service: coreServices.discovery, + deps: {}, + factory: () => discovery(), + }); export const mock = simpleMock(coreServices.discovery, () => ({ getBaseUrl: jest.fn(), getExternalBaseUrl: jest.fn(),