From 77893b657a7c4c0d231bd0c4bd9d4ba07b6e0177 Mon Sep 17 00:00:00 2001 From: blam Date: Wed, 31 Mar 2021 13:58:35 +0200 Subject: [PATCH] chore: add todo for later refactor Signed-off-by: blam --- .../src/scaffolder/actions/builtin/publish/github.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts index 1eff8eb7e2..7ade6ffd19 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.ts @@ -102,6 +102,8 @@ export function createPublishGithubAction(options: { ); } + // TODO(blam): Consider changing this API to have owner, repo interface instead of URL as the it's + // needless to create URL and then parse again the other side. const { token } = await credentialsProvider.getCredentials({ url: `https://${host}/${encodeURIComponent(owner)}/${encodeURIComponent( repo,