paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 33 Packages Projects Releases Wiki Activity

tests(catalog): Fix tests & Icon from system icons

Browse Source 
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
This commit is contained in:
Carlos Esteban Lopez
2023-05-19 15:02:27 -05:00
parent 08f177b910
commit 76cd142840
5 changed files with 179 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog/api-report.md
+7
View File
@@ -105,6 +105,13 @@ export const catalogPlugin: BackstagePlugin<
},
true
>;
selectedTemplateRoute: ExternalRouteRef<
{
namespace: string;
templateName: string;
},
true
>;
},
CatalogInputPluginOptions
>;
plugins/catalog/src/components/AboutCard/AboutCard.test.tsx
+162 -1
View File
@@ -30,7 +30,7 @@ import { renderInTestApp, TestApiProvider } from '@backstage/test-utils';
import userEvent from '@testing-library/user-event';
import { screen } from '@testing-library/react';
import React from 'react';
import { viewTechDocRouteRef } from '../../routes';
import { selectedTemplateRouteRef, viewTechDocRouteRef } from '../../routes';
import { AboutCard } from './AboutCard';
describe('<AboutCard />', () => {
@@ -505,4 +505,165 @@ describe('<AboutCard />', () => {
expect(screen.getByText('View TechDocs')).toBeVisible();
expect(screen.getByText('View TechDocs').closest('a')).toBeNull();
});
it('renders launch template link', async () => {
const entity = {
apiVersion: 'scaffolder.backstage.io/v1beta3',
kind: 'Template',
metadata: {
name: 'create-react-app-template',
namespace: 'default',
},
};
await renderInTestApp(
<TestApiProvider
apis={[
[
scmIntegrationsApiRef,
ScmIntegrationsApi.fromConfig(
new ConfigReader({
integrations: {
github: [
{
host: 'github.com',
token: '...',
},
],
},
}),
),
],
[catalogApiRef, catalogApi],
]}
>
<EntityProvider entity={entity}>
<AboutCard />
</EntityProvider>
</TestApiProvider>,
{
mountedRoutes: {
'/catalog/:namespace/:kind/:name': entityRouteRef,
'/create/templates/:namespace/:templateName':
selectedTemplateRouteRef,
},
},
);
expect(screen.getByText('Launch Template')).toBeVisible();
expect(screen.getByText('Launch Template').closest('a')).toHaveAttribute(
'href',
'/create/templates/default/create-react-app-template',
);
});
it.each([
{
testName: 'entity is not a template',
entity: {
apiVersion: 'scaffolder.backstage.io/v1beta3',
kind: 'Component',
metadata: {
name: 'create-react-app-template',
namespace: 'default',
},
},
},
{
testName: 'apiVersion is not scaffolder.backstage.io/v1beta3',
entity: {
apiVersion: 'v1',
kind: 'Template',
metadata: {
name: 'create-react-app-template',
namespace: 'default',
},
},
},
])(
'should not render launch template link when $testName',
async ({ entity }) => {
await renderInTestApp(
<TestApiProvider
apis={[
[
scmIntegrationsApiRef,
ScmIntegrationsApi.fromConfig(
new ConfigReader({
integrations: {
github: [
{
host: 'github.com',
token: '...',
},
],
},
}),
),
],
[catalogApiRef, catalogApi],
]}
>
<EntityProvider entity={entity}>
<AboutCard />
</EntityProvider>
</TestApiProvider>,
{
mountedRoutes: {
'/catalog/:namespace/:kind/:name': entityRouteRef,
'/create/templates/:namespace/:templateName':
selectedTemplateRouteRef,
},
},
);
expect(screen.queryByText('Launch Template')).toBeNull();
},
);
it('renders disabled launch template link when route is not bound', async () => {
const entity = {
apiVersion: 'scaffolder.backstage.io/v1beta3',
kind: 'Template',
metadata: {
name: 'create-react-app-template',
namespace: 'default',
},
};
await renderInTestApp(
<TestApiProvider
apis={[
[
scmIntegrationsApiRef,
ScmIntegrationsApi.fromConfig(
new ConfigReader({
integrations: {
github: [
{
host: 'github.com',
token: '...',
},
],
},
}),
),
],
[catalogApiRef, catalogApi],
]}
>
<EntityProvider entity={entity}>
<AboutCard />
</EntityProvider>
</TestApiProvider>,
{
mountedRoutes: {
'/catalog/:namespace/:kind/:name': entityRouteRef,
},
},
);
expect(screen.getByText('Launch Template')).toBeVisible();
expect(screen.getByText('Launch Template').closest('a')).toBeNull();
});
});
plugins/catalog/src/components/AboutCard/AboutCard.tsx
+7 -3
View File
@@ -30,6 +30,7 @@ import {
alertApiRef,
errorApiRef,
useApi,
useApp,
useRouteRef,
} from '@backstage/core-plugin-api';
import {
@@ -90,8 +91,8 @@ export interface AboutCardProps {
/**
* Exported publicly via the EntityAboutCard
*/
export function AboutCard(props: AboutCardProps) {
const { variant } = props;
export function AboutCard({ variant }: AboutCardProps) {
const app = useApp();
const classes = useStyles();
const { entity } = useEntity();
const scmIntegrationsApi = useApi(scmIntegrationsApiRef);
@@ -132,9 +133,12 @@ export function AboutCard(props: AboutCardProps) {
const subHeaderLinks = [viewInSource, viewInTechDocs];
if (isTemplateEntityV1beta3(entity)) {
const Icon = app.getSystemIcon('scaffolder') ?? AddIcon;
const launchTemplate: IconLinkVerticalProps = {
label: 'Launch Template',
icon: <AddIcon />,
icon: <Icon />,
disabled: !templateRoute,
href:
templateRoute &&
templateRoute({
plugins/scaffolder-backend-module-gitlab/api-report.md
+3 -3
View File
@@ -26,8 +26,8 @@ export const createGitlabProjectAccessTokenAction: (options: {
integrations: ScmIntegrationRegistry;
}) => TemplateAction<
{
projectId: string | number;
repoUrl: string;
projectId: string | number;
token?: string | undefined;
name?: string | undefined;
accessLevel?: number | undefined;
@@ -44,8 +44,8 @@ export const createGitlabProjectDeployTokenAction: (options: {
}) => TemplateAction<
{
name: string;
projectId: string | number;
repoUrl: string;
projectId: string | number;
token?: string | undefined;
username?: string | undefined;
scopes?: string[] | undefined;
@@ -63,8 +63,8 @@ export const createGitlabProjectVariableAction: (options: {
{
key: string;
value: string;
projectId: string | number;
repoUrl: string;
projectId: string | number;
variableType: string;
token?: string | undefined;
variableProtected?: boolean | undefined;