From 9957a2f5db3ff15dd94403768ee08673d66239a7 Mon Sep 17 00:00:00 2001 From: ashinsabu Date: Sun, 11 Jun 2023 22:53:39 +0530 Subject: [PATCH 1/4] fixes 18172: manifest type can now be undefined as well Signed-off-by: ashinsabu --- .../src/next/hooks/useTemplateParameterSchema.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/scaffolder-react/src/next/hooks/useTemplateParameterSchema.ts b/plugins/scaffolder-react/src/next/hooks/useTemplateParameterSchema.ts index d060b9a09f..73452f1670 100644 --- a/plugins/scaffolder-react/src/next/hooks/useTemplateParameterSchema.ts +++ b/plugins/scaffolder-react/src/next/hooks/useTemplateParameterSchema.ts @@ -29,5 +29,9 @@ export const useTemplateParameterSchema = (templateRef: string) => { [scaffolderApi, templateRef], ); - return { manifest: value as TemplateParameterSchema, loading, error }; + return { + manifest: value as TemplateParameterSchema | undefined, + loading, + error, + }; }; From a452bda74d7a5feeba23778a61374eeb7165a6ff Mon Sep 17 00:00:00 2001 From: ashinsabu Date: Sun, 11 Jun 2023 23:12:17 +0530 Subject: [PATCH 2/4] Created changeset corresponding to fix Signed-off-by: ashinsabu --- .changeset/strong-crabs-flow.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strong-crabs-flow.md diff --git a/.changeset/strong-crabs-flow.md b/.changeset/strong-crabs-flow.md new file mode 100644 index 0000000000..df7a534d85 --- /dev/null +++ b/.changeset/strong-crabs-flow.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-react': major +--- + +Fixed typescript casting bug for useTemplateParameterSchema hook From 2214d0954044d5eb7daad49355ddc151514ded3c Mon Sep 17 00:00:00 2001 From: ashinsabu Date: Tue, 13 Jun 2023 02:33:43 +0530 Subject: [PATCH 3/4] Updated API reports Signed-off-by: ashinsabu --- .changeset/strong-crabs-flow.md | 2 +- plugins/home/api-report.md | 2 +- plugins/scaffolder-react/alpha-api-report.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/strong-crabs-flow.md b/.changeset/strong-crabs-flow.md index df7a534d85..6f73678f96 100644 --- a/.changeset/strong-crabs-flow.md +++ b/.changeset/strong-crabs-flow.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-scaffolder-react': major +'@backstage/plugin-scaffolder-react': minor --- Fixed typescript casting bug for useTemplateParameterSchema hook diff --git a/plugins/home/api-report.md b/plugins/home/api-report.md index e4ff522062..71cd319672 100644 --- a/plugins/home/api-report.md +++ b/plugins/home/api-report.md @@ -44,7 +44,7 @@ export type ClockConfig = { export const ComponentAccordion: (props: { title: string; expanded?: boolean | undefined; - Content: () => JSX.Element; + Content: () => JSX.Element /** @public */; Actions?: (() => JSX.Element) | undefined; Settings?: (() => JSX.Element) | undefined; ContextProvider?: ((props: any) => JSX.Element) | undefined; diff --git a/plugins/scaffolder-react/alpha-api-report.md b/plugins/scaffolder-react/alpha-api-report.md index f988eb0831..58a3c8e208 100644 --- a/plugins/scaffolder-react/alpha-api-report.md +++ b/plugins/scaffolder-react/alpha-api-report.md @@ -289,7 +289,7 @@ export const useFormDataFromQuery: ( // @alpha (undocumented) export const useTemplateParameterSchema: (templateRef: string) => { - manifest: TemplateParameterSchema; + manifest: TemplateParameterSchema | undefined; loading: boolean; error: Error | undefined; }; From 1fd9bed21759246d6e814da1eee056d6eb228c55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Tue, 13 Jun 2023 14:51:07 +0200 Subject: [PATCH 4/4] fixup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- plugins/home/api-report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/home/api-report.md b/plugins/home/api-report.md index 71cd319672..e4ff522062 100644 --- a/plugins/home/api-report.md +++ b/plugins/home/api-report.md @@ -44,7 +44,7 @@ export type ClockConfig = { export const ComponentAccordion: (props: { title: string; expanded?: boolean | undefined; - Content: () => JSX.Element /** @public */; + Content: () => JSX.Element; Actions?: (() => JSX.Element) | undefined; Settings?: (() => JSX.Element) | undefined; ContextProvider?: ((props: any) => JSX.Element) | undefined;