From 453439985490ca026acdcc8fcd7d87382e6a3014 Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Sun, 12 Apr 2020 15:27:39 +0900 Subject: [PATCH 1/2] Fix build error on Safari MediaQueryList.addEventListener is not support on Safari and hence the build fails. Ref: https://developer.mozilla.org/en-US/docs/Web/API/MediaQueryList Closes https://github.com/spotify/backstage/issues/531 --- packages/app/src/ThemeContext.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/app/src/ThemeContext.tsx b/packages/app/src/ThemeContext.tsx index 4ee76d400e..3d5a04f22a 100644 --- a/packages/app/src/ThemeContext.tsx +++ b/packages/app/src/ThemeContext.tsx @@ -41,9 +41,9 @@ export function useThemeType(themeId: string): [string, () => void] { setTheme('auto'); } }; - mql.addEventListener('change', darkListener); + mql.addListener(darkListener); return () => { - mql.removeEventListener('change', darkListener); + mql.removeListener(darkListener); }; }); function toggleTheme() { From db92c693bfd4861d9088960941efaa38910a0e0a Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Sun, 12 Apr 2020 15:38:31 +0900 Subject: [PATCH 2/2] Fix broken tests due to MediaQueryList.addEventListener --- packages/app/src/App.test.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/app/src/App.test.tsx b/packages/app/src/App.test.tsx index 83fcc039a3..79f78e45e0 100644 --- a/packages/app/src/App.test.tsx +++ b/packages/app/src/App.test.tsx @@ -24,8 +24,8 @@ describe('App', () => { value: jest.fn(() => { return { matches: true, - addEventListener: jest.fn(), - removeEventListener: jest.fn(), + addListener: jest.fn(), + removeListener: jest.fn(), }; }), });