From a2217c28a10e7d04f97d0443486a3078a6e5ed40 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 22 Aug 2022 11:21:51 +0200 Subject: [PATCH 1/2] chore: empty strings are still strings, so if it's not set default to undefined to throw the correct error Signed-off-by: blam --- .../src/components/fields/EntityPicker/EntityPicker.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/scaffolder/src/components/fields/EntityPicker/EntityPicker.tsx b/plugins/scaffolder/src/components/fields/EntityPicker/EntityPicker.tsx index b7e3122c31..2aa72550c3 100644 --- a/plugins/scaffolder/src/components/fields/EntityPicker/EntityPicker.tsx +++ b/plugins/scaffolder/src/components/fields/EntityPicker/EntityPicker.tsx @@ -72,7 +72,7 @@ export const EntityPicker = ( const onSelect = useCallback( (_: any, value: string | null) => { - onChange(value || ''); + onChange(value ?? undefined); }, [onChange], ); From 9ffb75616d7e9477d4205d1c10e4b3b9a6a65a1b Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 22 Aug 2022 11:22:46 +0200 Subject: [PATCH 2/2] Added changeset Signed-off-by: blam --- .changeset/dry-games-end.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/dry-games-end.md diff --git a/.changeset/dry-games-end.md b/.changeset/dry-games-end.md new file mode 100644 index 0000000000..dc2f86ee10 --- /dev/null +++ b/.changeset/dry-games-end.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Fix bug with empty strings in `EntityPicker`