diff --git a/.changeset/serious-baboons-report.md b/.changeset/serious-baboons-report.md new file mode 100644 index 0000000000..77aafe2648 --- /dev/null +++ b/.changeset/serious-baboons-report.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Fixed multiple scrolls appearing on Page when added InfoCard with external bottom link diff --git a/packages/core-components/src/components/Link/Link.tsx b/packages/core-components/src/components/Link/Link.tsx index d1b9e2b7db..5809990b92 100644 --- a/packages/core-components/src/components/Link/Link.tsx +++ b/packages/core-components/src/components/Link/Link.tsx @@ -15,6 +15,7 @@ */ import { useAnalytics } from '@backstage/core-plugin-api'; +import classnames from 'classnames'; import MaterialLink, { LinkProps as MaterialLinkProps, } from '@material-ui/core/Link'; @@ -36,6 +37,9 @@ const useStyles = makeStyles( height: 1, width: 1, }, + externalLink: { + position: 'relative', + }, }, { name: 'Link' }, ); @@ -100,6 +104,7 @@ export const Link = React.forwardRef( onClick={handleClick} {...(newWindow ? { target: '_blank', rel: 'noopener' } : {})} {...props} + className={classnames(classes.externalLink, props.className)} > {props.children} , Opens in a new window diff --git a/plugins/git-release-manager/src/features/Features.test.tsx b/plugins/git-release-manager/src/features/Features.test.tsx index 110c3e2351..a77dcfe9fc 100644 --- a/plugins/git-release-manager/src/features/Features.test.tsx +++ b/plugins/git-release-manager/src/features/Features.test.tsx @@ -72,7 +72,7 @@ describe('Features', () => { : The source control system where releases reside in a practical sense. Read more about