From 7365cccad264a831e6088e4e3c90e3ad51bcc432 Mon Sep 17 00:00:00 2001 From: Jonah Back Date: Sun, 26 Jun 2022 13:22:53 -0700 Subject: [PATCH] address review comments Signed-off-by: Jonah Back --- packages/catalog-model/api-report.md | 11 +++++++++++ .../src/processors/AwsEKSClusterProcessor.ts | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/catalog-model/api-report.md b/packages/catalog-model/api-report.md index 8427ef4112..6cfc49532f 100644 --- a/packages/catalog-model/api-report.md +++ b/packages/catalog-model/api-report.md @@ -14,6 +14,17 @@ export interface AlphaEntity extends Entity { // @public export const ANNOTATION_EDIT_URL = 'backstage.io/edit-url'; +// @public +export const ANNOTATION_KUBERNETES_API_SERVER = 'kubernetes.io/api-server'; + +// @public +export const ANNOTATION_KUBERNETES_API_SERVER_CA = + 'kubernetes.io/api-server-certificate-authority'; + +// @public +export const ANNOTATION_KUBERNETES_AUTH_PROVIDER = + 'kubernetes.io/auth-provider'; + // @public export const ANNOTATION_LOCATION = 'backstage.io/managed-by-location'; diff --git a/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.ts b/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.ts index ca45b28f5d..c85531e944 100644 --- a/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.ts +++ b/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.ts @@ -32,8 +32,8 @@ const ARN_ANNOTATION: string = 'amazonaws.com/arn'; export class AwsEKSClusterProcessor implements CatalogProcessor { private credentialsFactory?: AWSCredentialFactory; - constructor(credentialsFactory?: AWSCredentialFactory) { - this.credentialsFactory = credentialsFactory; + constructor(options: { credentialsFactory?: AWSCredentialFactory }) { + this.credentialsFactory = options.credentialsFactory; } getProcessorName(): string {