From 72eccc0f5dc6dbbf52df81b12105c74892caa343 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 26 Jan 2022 17:47:26 +0100
Subject: [PATCH] chore: added tests for ensuring that the token is used
 properly when passed into the actions Signed-off-by: blam <ben@blam.sh>

---
 .../actions/builtin/publish/azure.test.ts     | 26 +++++++++++++
 .../actions/builtin/publish/bitbucket.test.ts | 39 +++++++++++++++++++
 .../actions/builtin/publish/gitlab.test.ts    | 22 +++++++++++
 3 files changed, 87 insertions(+)

diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/azure.test.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/azure.test.ts
index cee99e1646..9247109121 100644
--- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/azure.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/azure.test.ts
@@ -119,6 +119,32 @@ describe('publish:azure', () => {
     ).rejects.toThrow(/Unable to create the repository/);
   });
 
+  it('should not throw if there is a token provided through ctx.input', async () => {
+    mockGitClient.createRepository.mockImplementation(() => ({
+      remoteUrl: 'http://google.com',
+    }));
+
+    await action.handler({
+      ...mockContext,
+      input: {
+        repoUrl: 'myazurehostnotoken.com?repo=bob&owner=owner&organization=org',
+        token: 'lols',
+      },
+    });
+
+    expect(WebApi).toHaveBeenCalledWith(
+      'https://myazurehostnotoken.com/org',
+      expect.any(Function),
+    );
+
+    expect(mockGitClient.createRepository).toHaveBeenCalledWith(
+      {
+        name: 'bob',
+      },
+      'owner',
+    );
+  });
+
   it('should throw if there is no remoteUrl returned', async () => {
     mockGitClient.createRepository.mockImplementation(() => ({
       remoteUrl: null,
diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/bitbucket.test.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/bitbucket.test.ts
index 2678abd9dd..3d14710f3e 100644
--- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/bitbucket.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/bitbucket.test.ts
@@ -194,6 +194,45 @@ describe('publish:bitbucket', () => {
     });
   });
 
+  it('should work if the token is provided through ctx.input', async () => {
+    expect.assertions(2);
+    server.use(
+      rest.post(
+        'https://notoken.bitbucket.com/rest/api/1.0/projects/project/repos',
+        (req, res, ctx) => {
+          expect(req.headers.get('Authorization')).toBe('Bearer lols');
+          expect(req.body).toEqual({ public: false, name: 'repo' });
+          return res(
+            ctx.status(201),
+            ctx.set('Content-Type', 'application/json'),
+            ctx.json({
+              links: {
+                self: [
+                  {
+                    href: 'https://bitbucket.mycompany.com/projects/project/repos/repo',
+                  },
+                ],
+                clone: [
+                  {
+                    name: 'http',
+                    href: 'https://bitbucket.mycompany.com/scm/project/repo',
+                  },
+                ],
+              },
+            }),
+          );
+        },
+      ),
+    );
+    await action.handler({
+      ...mockContext,
+      input: {
+        repoUrl: 'notoken.bitbucket.com?project=project&repo=repo',
+        token: 'lols',
+      },
+    });
+  });
+
   describe('LFS for hosted bitbucket', () => {
     const repoCreationResponse = {
       links: {
diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/gitlab.test.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/gitlab.test.ts
index 2cd27da359..a32fea8830 100644
--- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/gitlab.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/gitlab.test.ts
@@ -96,6 +96,28 @@ describe('publish:gitlab', () => {
     ).rejects.toThrow(/No token available for host/);
   });
 
+  it('should work when there is a token provided through ctx.input', async () => {
+    mockGitlabClient.Namespaces.show.mockResolvedValue({ id: 1234 });
+    mockGitlabClient.Projects.create.mockResolvedValue({
+      http_url_to_repo: 'http://mockurl.git',
+    });
+
+    await action.handler({
+      ...mockContext,
+      input: {
+        repoUrl: 'hosted.gitlab.com?repo=bob&owner=owner',
+        token: 'token',
+      },
+    });
+
+    expect(mockGitlabClient.Namespaces.show).toHaveBeenCalledWith('owner');
+    expect(mockGitlabClient.Projects.create).toHaveBeenCalledWith({
+      namespace_id: 1234,
+      name: 'bob',
+      visibility: 'private',
+    });
+  });
+
   it('should call the correct Gitlab APIs when the owner is an organization', async () => {
     mockGitlabClient.Namespaces.show.mockResolvedValue({ id: 1234 });
     mockGitlabClient.Projects.create.mockResolvedValue({