From 72df7c623ad68cdc2cc2622d4312147e96448cbf Mon Sep 17 00:00:00 2001 From: Aditya Kumar Date: Tue, 19 Mar 2024 11:02:32 +0530 Subject: [PATCH] Add ESLint Rule to Signals Plugin Signed-off-by: Aditya Kumar --- .changeset/unlucky-drinks-glow.md | 5 +++++ plugins/signals/.eslintrc.js | 6 +++++- plugins/signals/dev/index.tsx | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 .changeset/unlucky-drinks-glow.md diff --git a/.changeset/unlucky-drinks-glow.md b/.changeset/unlucky-drinks-glow.md new file mode 100644 index 0000000000..6e14095a62 --- /dev/null +++ b/.changeset/unlucky-drinks-glow.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-signals': patch +--- + +Added ESLint rule `no-top-level-material-ui-4-imports` in the `signals` plugin to migrate the Material UI imports. diff --git a/plugins/signals/.eslintrc.js b/plugins/signals/.eslintrc.js index e2a53a6ad2..a2d8179106 100644 --- a/plugins/signals/.eslintrc.js +++ b/plugins/signals/.eslintrc.js @@ -1 +1,5 @@ -module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { + rules: { + '@backstage/no-top-level-material-ui-4-imports': 'error', + }, +}); diff --git a/plugins/signals/dev/index.tsx b/plugins/signals/dev/index.tsx index e8c7928f57..2b22424eee 100644 --- a/plugins/signals/dev/index.tsx +++ b/plugins/signals/dev/index.tsx @@ -17,7 +17,7 @@ import React from 'react'; import { createDevApp } from '@backstage/dev-utils'; import { signalsPlugin } from '../src/plugin'; import { Content, Header, Page } from '@backstage/core-components'; -import { Typography } from '@material-ui/core'; +import Typography from '@material-ui/core/Typography'; createDevApp() .registerPlugin(signalsPlugin)