From 72c98655f3a4f3e9df30ca7b0770337210bfb9d6 Mon Sep 17 00:00:00 2001 From: blam Date: Fri, 10 Apr 2020 01:38:35 +0200 Subject: [PATCH] chore; fixing code review commenta and fix the import path --- packages/app/src/plugins.ts | 7 +++---- .../cli/templates/default-app/packages/app/src/plugins.ts | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/app/src/plugins.ts b/packages/app/src/plugins.ts index e1ad92c0fa..919ea0666b 100644 --- a/packages/app/src/plugins.ts +++ b/packages/app/src/plugins.ts @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { plugin as HomePagePlugin } from '@backstage/plugin-home-page'; -import { plugin as WelcomePlugin } from '@backstage/plugin-welcome'; -import { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse'; -export { HomePagePlugin, WelcomePlugin, LighthousePlugin }; +export { plugin as HomePagePlugin } from '@backstage/plugin-home-page'; +export { plugin as WelcomePlugin } from '@backstage/plugin-welcome'; +export { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse'; diff --git a/packages/cli/templates/default-app/packages/app/src/plugins.ts b/packages/cli/templates/default-app/packages/app/src/plugins.ts index 6639319bbd..000bd79f3e 100644 --- a/packages/cli/templates/default-app/packages/app/src/plugins.ts +++ b/packages/cli/templates/default-app/packages/app/src/plugins.ts @@ -1 +1 @@ -export { default as WelcomePlugin } from 'plugin-welcome'; +export { plugin as WelcomePlugin } from 'plugin-welcome';