From 72becbd2cc5fa95246da21b234c4f916e2a8cb9b Mon Sep 17 00:00:00 2001
From: Johan Haals <johan.haals@gmail.com>
Date: Tue, 27 Apr 2021 14:16:49 +0200
Subject: [PATCH] catalog-backend: Add ConfigLocationProvider tests

Co-authored-by: Ben Lambert <ben@blam.sh>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
---
 .../src/next/ConfigLocationProvider.test.ts   | 67 +++++++++++++++++++
 .../src/next/ConfigLocationProvider.ts        | 14 ++--
 2 files changed, 75 insertions(+), 6 deletions(-)
 create mode 100644 plugins/catalog-backend/src/next/ConfigLocationProvider.test.ts

diff --git a/plugins/catalog-backend/src/next/ConfigLocationProvider.test.ts b/plugins/catalog-backend/src/next/ConfigLocationProvider.test.ts
new file mode 100644
index 0000000000..9aaba13c48
--- /dev/null
+++ b/plugins/catalog-backend/src/next/ConfigLocationProvider.test.ts
@@ -0,0 +1,67 @@
+/*
+ * Copyright 2021 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { ConfigLocationProvider } from './ConfigLocationProvider';
+import { EntityProviderConnection } from './types';
+import { ConfigReader } from '@backstage/config';
+import { resolvePackagePath } from '@backstage/backend-common';
+import path from 'path';
+
+describe('Config Location Provider', () => {
+  it('should apply mutation with the correct paths in the config', async () => {
+    const mockConfig = new ConfigReader({
+      catalog: {
+        locations: [
+          { type: 'file', target: './lols.yaml' },
+          { type: 'url', target: 'https://github.com/backstage/backstage' },
+        ],
+      },
+    });
+
+    const mockConnection = ({
+      applyMutation: jest.fn(),
+    } as unknown) as EntityProviderConnection;
+    const locationProvider = new ConfigLocationProvider(mockConfig);
+
+    await locationProvider.connect(mockConnection);
+
+    expect(mockConnection.applyMutation).toHaveBeenCalledWith({
+      type: 'full',
+      entities: expect.arrayContaining([
+        expect.objectContaining({
+          spec: {
+            target: path.join(
+              resolvePackagePath('@backstage/plugin-catalog-backend'),
+              './lols.yaml',
+            ),
+            type: 'file',
+          },
+        }),
+      ]),
+    });
+    expect(mockConnection.applyMutation).toHaveBeenCalledWith({
+      type: 'full',
+      entities: expect.arrayContaining([
+        expect.objectContaining({
+          spec: {
+            target: 'https://github.com/backstage/backstage',
+            type: 'url',
+          },
+        }),
+      ]),
+    });
+  });
+});
diff --git a/plugins/catalog-backend/src/next/ConfigLocationProvider.ts b/plugins/catalog-backend/src/next/ConfigLocationProvider.ts
index 5b93fcfd98..8a65487df1 100644
--- a/plugins/catalog-backend/src/next/ConfigLocationProvider.ts
+++ b/plugins/catalog-backend/src/next/ConfigLocationProvider.ts
@@ -34,12 +34,14 @@ export class ConfigLocationProvider implements EntityProvider {
     const locationConfigs =
       this.config.getOptionalConfigArray('catalog.locations') ?? [];
 
-    const entities = locationConfigs.map(location =>
-      locationSpecToLocationEntity({
-        type: location.getString('type'),
-        target: path.resolve(location.getString('target')),
-      }),
-    );
+    const entities = locationConfigs.map(location => {
+      const type = location.getString('type');
+      const target = location.getString('target');
+      return locationSpecToLocationEntity({
+        type,
+        target: type === 'file' ? path.resolve(target) : target,
+      });
+    });
 
     await this.connection.applyMutation({
       type: 'full',