From 434994bfee1810cc2ceb06a872150be7b7144a52 Mon Sep 17 00:00:00 2001 From: ellinors Date: Wed, 1 Jul 2020 14:28:07 +0200 Subject: [PATCH 1/3] Code change to remove React.FC in SentryIssueTable.tsx, testing it out --- .../src/components/SentryIssuesTable/SentryIssuesTable.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sentry/src/components/SentryIssuesTable/SentryIssuesTable.tsx b/plugins/sentry/src/components/SentryIssuesTable/SentryIssuesTable.tsx index cebd5563f4..aae8009d98 100644 --- a/plugins/sentry/src/components/SentryIssuesTable/SentryIssuesTable.tsx +++ b/plugins/sentry/src/components/SentryIssuesTable/SentryIssuesTable.tsx @@ -14,7 +14,7 @@ * limitations under the License. */ -import React, { FC } from 'react'; +import React from 'react'; import { Table, TableColumn } from '@backstage/core'; import { SentryIssue } from '../../data/sentry-issue'; import { format } from 'timeago.js'; @@ -60,7 +60,7 @@ type SentryIssuesTableProps = { sentryIssues: SentryIssue[]; }; -const SentryIssuesTable: FC = ({ sentryIssues }) => { +const SentryIssuesTable = ({ sentryIssues }: SentryIssuesTableProps) => { return ( Date: Wed, 1 Jul 2020 14:53:51 +0200 Subject: [PATCH 2/3] Removed React.FC from welcome page --- plugins/welcome/src/components/WelcomePage/WelcomePage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx index ce151737b3..c77d7eacd1 100644 --- a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx +++ b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx @@ -14,7 +14,7 @@ * limitations under the License. */ -import React, { FC } from 'react'; +import React from 'react'; import { Link as RouterLink } from 'react-router-dom'; import { Typography, @@ -38,7 +38,7 @@ import { configApiRef, } from '@backstage/core'; -const WelcomePage: FC<{}> = () => { +const WelcomePage = ({}) => { const appTitle = useApi(configApiRef).getOptionalString('app.title') ?? 'Backstage'; const profile = { givenName: '' }; From 9ef217e6b876753b3f98f7bbbdeb35c43a338311 Mon Sep 17 00:00:00 2001 From: ellinors Date: Wed, 1 Jul 2020 17:37:51 +0200 Subject: [PATCH 3/3] removed unnecessary curly brackets --- plugins/welcome/src/components/WelcomePage/WelcomePage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx index c77d7eacd1..272297ed45 100644 --- a/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx +++ b/plugins/welcome/src/components/WelcomePage/WelcomePage.tsx @@ -38,7 +38,7 @@ import { configApiRef, } from '@backstage/core'; -const WelcomePage = ({}) => { +const WelcomePage = () => { const appTitle = useApi(configApiRef).getOptionalString('app.title') ?? 'Backstage'; const profile = { givenName: '' };