From 80f07624cd20976cc0ba3802c9213ac02a7873dd Mon Sep 17 00:00:00 2001 From: Shashank Bairy R Date: Sun, 9 May 2021 00:02:50 +0530 Subject: [PATCH 1/3] Add context for versions:bump about version change and update tests Signed-off-by: Shashank Bairy R --- packages/cli/src/commands/versions/bump.test.ts | 2 +- packages/cli/src/commands/versions/bump.ts | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/commands/versions/bump.test.ts b/packages/cli/src/commands/versions/bump.test.ts index 31803d4827..e5128fc995 100644 --- a/packages/cli/src/commands/versions/bump.test.ts +++ b/packages/cli/src/commands/versions/bump.test.ts @@ -136,7 +136,7 @@ describe('bump', () => { 'bumping @backstage/theme in b to ^2.0.0', 'Running yarn install to install new versions', '⚠️ The following packages may have breaking changes:', - ' @backstage/theme', + ' @backstage/theme : 1.0.0 ~> 2.0.0', ' https://github.com/backstage/backstage/blob/master/packages/theme/CHANGELOG.md', 'Version bump complete!', ]); diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts index ceb2f7f988..642b93f242 100644 --- a/packages/cli/src/commands/versions/bump.ts +++ b/packages/cli/src/commands/versions/bump.ts @@ -195,8 +195,14 @@ export default async () => { ); console.log(); - for (const name of Array.from(breakingUpdates.keys()).sort()) { - console.log(` ${chalk.yellow(name)}`); + for (const [name, { from, to }] of [ + ...breakingUpdates.entries(), + ].sort()) { + console.log( + ` ${chalk.yellow(name)} : ${chalk.yellow(from)} ~> ${chalk.yellow( + to, + )}`, + ); let path; if (name.startsWith('@backstage/plugin-')) { From 2cd70e1646109d9a42f5de8f42bc691fc975873e Mon Sep 17 00:00:00 2001 From: Shashank Bairy R Date: Sun, 9 May 2021 00:08:36 +0530 Subject: [PATCH 2/3] Add changeset Signed-off-by: Shashank Bairy R --- .changeset/beige-cheetahs-jog.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-cheetahs-jog.md diff --git a/.changeset/beige-cheetahs-jog.md b/.changeset/beige-cheetahs-jog.md new file mode 100644 index 0000000000..87ef3ef44c --- /dev/null +++ b/.changeset/beige-cheetahs-jog.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Add context for versions:bump on what version it was bumped to. Updated tests for the same. From d40316a7fd4a44d929b8a868eaa6e35c8ac0b458 Mon Sep 17 00:00:00 2001 From: Shashank Bairy R Date: Sun, 9 May 2021 11:58:40 +0530 Subject: [PATCH 3/3] use Array.from instead of spread operator Signed-off-by: Shashank Bairy R --- packages/cli/src/commands/versions/bump.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts index 642b93f242..d046283aab 100644 --- a/packages/cli/src/commands/versions/bump.ts +++ b/packages/cli/src/commands/versions/bump.ts @@ -195,9 +195,9 @@ export default async () => { ); console.log(); - for (const [name, { from, to }] of [ - ...breakingUpdates.entries(), - ].sort()) { + for (const [name, { from, to }] of Array.from( + breakingUpdates.entries(), + ).sort()) { console.log( ` ${chalk.yellow(name)} : ${chalk.yellow(from)} ~> ${chalk.yellow( to,