fix(catalog): show not-found instead of falling back to first route on unknown entity sub-paths (#34081)
* fix(catalog): show not-found instead of falling back to first route on unknown entity sub-paths Signed-off-by: benjdlambert <ben@blam.sh> * fix(catalog): address PR review feedback Signed-off-by: benjdlambert <ben@blam.sh> * fix(core-compat-api): update entity page conversion test for new not-found behavior Signed-off-by: benjdlambert <ben@blam.sh> * fix(catalog): use NotFoundErrorPage and drop redundant route sort Signed-off-by: benjdlambert <ben@blam.sh> * fix(catalog): split slash trimming into two replacements for clarity Signed-off-by: benjdlambert <ben@blam.sh> * fix(catalog): comment normalizeRoutePath regex and memoize routes Signed-off-by: benjdlambert <ben@blam.sh> * fix(catalog): preserve explicit trailing wildcards in route paths Signed-off-by: benjdlambert <ben@blam.sh> --------- Signed-off-by: benjdlambert <ben@blam.sh>
This commit is contained in:
@@ -317,9 +317,10 @@ describe('convertLegacyApp', () => {
|
||||
features: [catalogOverride, ...converted],
|
||||
initialRouteEntries: ['/catalog/default/other/x/bar'],
|
||||
});
|
||||
// /bar does not exist on the "other" entity layout, expect the not-found page.
|
||||
await expect(
|
||||
renderBarOther.findByText('other overview content', {}, findOptions),
|
||||
).resolves.toBeInTheDocument(); // /bar does not exist, fall back to rendering overview
|
||||
renderBarOther.findByTestId('error', {}, findOptions),
|
||||
).resolves.toBeInTheDocument();
|
||||
renderBarOther.unmount();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user