From 71fb4e1281b57754ed8cb9765bba2018678d98a4 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Wed, 13 Jan 2021 16:58:11 +0100 Subject: [PATCH] cli: Remove api url from github app configuration --- .../src/commands/create-github-app/GithubCreateAppServer.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts b/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts index 406e563ebc..45671c2ead 100644 --- a/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts +++ b/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts @@ -47,7 +47,6 @@ const FORM_PAGE = ` type GithubAppConfig = { appId: number; - apiUrl: string; slug?: string; name?: string; webhookUrl?: string; @@ -88,14 +87,11 @@ export class GithubCreateAppServer { `POST /app-manifests/${encodeURIComponent( req.query.code as string, )}/conversions`, - ).then(({ data, url }) => { - // url = https://api.github.com/app-manifests//conversions - const apiUrl = url.replace(/(?:\/[^\/]+){3}$/, ''); + ).then(({ data }) => { resolve({ name: data.name, slug: data.slug, appId: data.id, - apiUrl, webhookUrl: this.webhookUrl, clientId: data.client_id, clientSecret: data.client_secret,