From caf1da5c450ad139c4f7f5ecdc841373ca9dab87 Mon Sep 17 00:00:00 2001 From: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com> Date: Wed, 15 May 2024 13:52:53 +0200 Subject: [PATCH 1/2] add hint about default behaviour of branch filter (in old backend docs)) I would have expected the Discovery Processor to look at all branches. Having this hint would be nice. Signed-off-by: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com> --- docs/integrations/github/discovery--old.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/integrations/github/discovery--old.md b/docs/integrations/github/discovery--old.md index b94cb256c4..138e54a538 100644 --- a/docs/integrations/github/discovery--old.md +++ b/docs/integrations/github/discovery--old.md @@ -200,6 +200,7 @@ This provider supports multiple organizations via unique provider IDs. - **`filters`** _(optional)_: - **`branch`** _(optional)_: String used to filter results based on the branch name. + Defaults to the default Branch of the repository. - **`repository`** _(optional)_: Regular expression used to filter results based on the repository name. - **`topic`** _(optional)_: From 55ca3f992e94de03fc93b9041826147432f6e4d6 Mon Sep 17 00:00:00 2001 From: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com> Date: Wed, 15 May 2024 13:53:45 +0200 Subject: [PATCH 2/2] add hint about default behaviour of branch filter I would have expected the Discovery Processor to look at all branches. Having this hint would be nice. Signed-off-by: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com> --- docs/integrations/github/discovery.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/integrations/github/discovery.md b/docs/integrations/github/discovery.md index f16d1c17b2..e16c9da202 100644 --- a/docs/integrations/github/discovery.md +++ b/docs/integrations/github/discovery.md @@ -141,6 +141,7 @@ This provider supports multiple organizations via unique provider IDs. - **`filters`** _(optional)_: - **`branch`** _(optional)_: String used to filter results based on the branch name. + Defaults to the default Branch of the repository. - **`repository`** _(optional)_: Regular expression used to filter results based on the repository name. - **`topic`** _(optional)_: