From 718f66f235b86537d2cd29342d9342efbc6739be Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Wed, 9 Nov 2022 16:49:26 -0500 Subject: [PATCH] fix: Handle skipTLSVerify properly Signed-off-by: Carlos Esteban Lopez --- .../src/service/KubernetesProxy.ts | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/kubernetes-backend/src/service/KubernetesProxy.ts b/plugins/kubernetes-backend/src/service/KubernetesProxy.ts index d1a34cb2cf..9da0068072 100644 --- a/plugins/kubernetes-backend/src/service/KubernetesProxy.ts +++ b/plugins/kubernetes-backend/src/service/KubernetesProxy.ts @@ -160,17 +160,17 @@ export class KubernetesProxy { headers: headers as { [key: string]: string }, }; - if (!details.skipTLSVerify) { - if (details.caData) { - const ca = bufferFromFileOrString('', details.caData)?.toString() || ''; - reqData.agent = new https.Agent({ ca }); - } else { - this.logger.error('could not find CA certificate!'); + if (details.skipTLSVerify) { + reqData.agent = new https.Agent({ rejectUnauthorized: false }); + } else if (details.caData) { + const ca = bufferFromFileOrString('', details.caData)?.toString() || ''; + reqData.agent = new https.Agent({ ca }); + } else { + this.logger.error('could not find CA certificate!'); - throw new InputError( - 'Invalid CA certificate configured within Backstage', - ); - } + throw new InputError( + 'Invalid CA certificate configured within Backstage', + ); } if (body && Object.keys(body).length > 0) {