From 718ef6063813b8964c5bac7800b7e0e425fbd96c Mon Sep 17 00:00:00 2001
From: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
Date: Wed, 1 Mar 2023 17:55:24 -0500
Subject: [PATCH] tests(search): Fix tests broken by change from placeholder to
 label

Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
---
 .../SearchAutocomplete.test.tsx               |  6 ++---
 .../components/SearchBar/SearchBar.test.tsx   | 25 ++++++++++++++++---
 .../src/components/SearchBar/SearchBar.tsx    |  9 ++++---
 3 files changed, 30 insertions(+), 10 deletions(-)

diff --git a/plugins/search-react/src/components/SearchAutocomplete/SearchAutocomplete.test.tsx b/plugins/search-react/src/components/SearchAutocomplete/SearchAutocomplete.test.tsx
index d9da187541..54deca5f5d 100644
--- a/plugins/search-react/src/components/SearchAutocomplete/SearchAutocomplete.test.tsx
+++ b/plugins/search-react/src/components/SearchAutocomplete/SearchAutocomplete.test.tsx
@@ -74,7 +74,7 @@ describe('SearchAutocomplete', () => {
     expect(screen.queryByText(options[1])).not.toBeInTheDocument();
     expect(screen.queryByText(options[2])).not.toBeInTheDocument();
 
-    await userEvent.click(screen.getByPlaceholderText(`Search in ${title}`));
+    await userEvent.click(screen.getByLabelText(`Search in ${title}`));
 
     await waitFor(() => {
       expect(screen.getByText(options[0])).toBeInTheDocument();
@@ -150,7 +150,7 @@ describe('SearchAutocomplete', () => {
       </TestApiProvider>,
     );
 
-    await userEvent.click(screen.getByPlaceholderText(`Search in ${title}`));
+    await userEvent.click(screen.getByLabelText(`Search in ${title}`));
 
     await userEvent.click(screen.getByText(options[0]));
 
@@ -218,7 +218,7 @@ describe('SearchAutocomplete', () => {
       </TestApiProvider>,
     );
 
-    await userEvent.click(screen.getByPlaceholderText(`Search in ${title}`));
+    await userEvent.click(screen.getByLabelText(`Search in ${title}`));
 
     await waitFor(() => {
       expect(screen.getAllByTitle('Option icon')).toHaveLength(3);
diff --git a/plugins/search-react/src/components/SearchBar/SearchBar.test.tsx b/plugins/search-react/src/components/SearchBar/SearchBar.test.tsx
index fba50f74d8..30df27aba7 100644
--- a/plugins/search-react/src/components/SearchBar/SearchBar.test.tsx
+++ b/plugins/search-react/src/components/SearchBar/SearchBar.test.tsx
@@ -70,9 +70,28 @@ describe('SearchBar', () => {
     );
 
     await waitFor(() => {
-      expect(
-        screen.getByPlaceholderText('Search in Mock title'),
-      ).toBeInTheDocument();
+      expect(screen.getByLabelText('Search in Mock title')).toBeInTheDocument();
+    });
+  });
+
+  it('Renders with custom label', async () => {
+    const label = 'label';
+
+    const result = await renderWithEffects(
+      <TestApiProvider
+        apis={[
+          [configApiRef, configApiMock],
+          [searchApiRef, searchApiMock],
+        ]}
+      >
+        <SearchContextProvider>
+          <SearchBar label={label} />
+        </SearchContextProvider>
+      </TestApiProvider>,
+    );
+
+    await waitFor(() => {
+      expect(result.getByLabelText(label)).toBeInTheDocument();
     });
   });
 
diff --git a/plugins/search-react/src/components/SearchBar/SearchBar.tsx b/plugins/search-react/src/components/SearchBar/SearchBar.tsx
index 1be8043b65..72d3559eb0 100644
--- a/plugins/search-react/src/components/SearchBar/SearchBar.tsx
+++ b/plugins/search-react/src/components/SearchBar/SearchBar.tsx
@@ -78,7 +78,7 @@ export const SearchBarBase: ForwardRefExoticComponent<SearchBarBaseProps> =
         clearButton = true,
         fullWidth = true,
         value: defaultValue,
-        placeholder: defaultPlaceholder,
+        label: defaultLabel,
         inputProps: defaultInputProps = {},
         endAdornment: defaultEndAdornment,
         ...rest
@@ -119,8 +119,8 @@ export const SearchBarBase: ForwardRefExoticComponent<SearchBarBaseProps> =
         }
       }, [onChange, onClear]);
 
-      const placeholder =
-        defaultPlaceholder ??
+      const label =
+        defaultLabel ??
         `Search in ${configApi.getOptionalString('app.title') || 'Backstage'}`;
 
       const startAdornment = (
@@ -142,12 +142,13 @@ export const SearchBarBase: ForwardRefExoticComponent<SearchBarBaseProps> =
       return (
         <TrackSearch>
           <TextField
+            id="search-bar-text-field"
             data-testid="search-bar-next"
             variant="outlined"
             margin="normal"
             inputRef={ref}
             value={value}
-            label={placeholder}
+            label={label}
             InputProps={{
               startAdornment,
               endAdornment: clearButton ? endAdornment : defaultEndAdornment,